distcc --scan-includes dumps core

[GoogleCodeExporter]

This is r644.

Original issue reported on code.google.com by akim.demaille@gmail.com on 8 Jan 2009 at 10:26

Attachments:

• scan-includes.patch

[GoogleCodeExporter]

Thanks for the patch!

When there's an error parsing the command-line arguments, distcc should return
EXIT_BAD_ARGUMENTS, i.e. 101, rather than 1 or 2.

You updated the copyright date, but in the line that said "Copyright ... by 
Martin
Pool".  That doesn't seem right.  Either leave the copyright messages alone, or 
add a
new one with your name.  (For a simple change like this, I suggest leaving the
copyright messages unchanged, but I don't mind either way.)

Thanks for the detailed description in the ChangeLog; such change descriptions 
help
to make reviewing the change easier and for understanding things later.  
However, the
ChangeLog file is now semi-automatically generated from the svn logs at each 
release,
rather than being manually maintained at each submit.  So it's sufficient to 
just
include the description in the svn log message at commit time, rather than 
patching
the ChangeLog.

Otherwise, this looks great.  Do you want to apply it (submit the change to 
svn), or
shall I?

P.S. I've modified the patch to address the minor concerns mentioned above.  See
attached.

Original comment by fergus.h...@gmail.com on 8 Jan 2009 at 8:41

• Changed state: Started
• Added labels: Type-Patch

Attachments:

• patch

[GoogleCodeExporter]

Hi Fergus,

I did not know I could directly submit my changes via svn.  I checked out
again following the instructions in the "Source" tab, but found nothing
about "submitting" a change, so I went ahead and applied the patch you
sent me.  Is that what I'm supposed to do?  The instructions for the
developpers on the wiki are a bit terse :)

Have I done right?

Original comment by akim.demaille@gmail.com on 9 Jan 2009 at 8:58

[GoogleCodeExporter]

You did great!  Thanks!!

Original comment by fergus.h...@gmail.com on 9 Jan 2009 at 10:51

[GoogleCodeExporter]

Original comment by fergus.h...@gmail.com on 9 Jan 2009 at 10:51

• Changed state: Fixed