Zeroconf fails if avahi supports IPv6

[GoogleCodeExporter]

I am running distcc 3.0 i686-pc-linux-gnu on a gentoo system with GCC
4.1.2.  On any compile, or running 'distcc --show-hosts' I get an "ERROR:
invalid tcp port specification in "<ipv6 address here>""

Because of this, distcc fails to work with zeroconf on my network (or any
network where zeroconf reports IPv6 adresses).

The best solution is to either fix the address parsing so that zeroconf's
IPv6 addresses parse correctly, or to force avahi to give only IPv4 addresses.

Original issue reported on code.google.com by ads...@gmail.com on 13 Jan 2009 at 9:54

[GoogleCodeExporter]

Thanks for the bug report.  A patch would be even nicer!

Original comment by fergus.h...@gmail.com on 13 Jan 2009 at 3:50

[GoogleCodeExporter]

I'm working on one, but figured I'd submit a bug-report just in case it's been 
fixed
already.

Original comment by ads...@gmail.com on 14 Jan 2009 at 5:58

[GoogleCodeExporter]

Sure, good idea.  There's no fix yet, as far as I know..

May be worth looping in Lennart Poettering, the original author of avahi 
support in distcc.

Original comment by fergus.h...@gmail.com on 14 Jan 2009 at 7:19

[GoogleCodeExporter]

Sure, good idea.  There's no fix yet, as far as I know..

May be worth looping in Lennart Poettering, the original author of avahi 
support in distcc.

Original comment by fergus.h...@gmail.com on 14 Jan 2009 at 7:20

[GoogleCodeExporter]

I've fixed the problem by adding IPv6 literal host support to the TCP host 
parser and
making the zeroconf host file writer handle IPv6 Hosts properly.  I also update 
the
requisite parts of the distcc manpage.

Known/suspected remaining bugs:
* If avahi returns the same host on both IPv4 and IPv6, it will be entered into 
the
host list twice.
* This patch doesn't pay attention to the IPv6 configure flags, so there may be
problems there that usually won't be encountered when a user without IPv6 
support
tries to use an IPv6 literal in his host file.

Original comment by ads...@gmail.com on 17 Jan 2009 at 9:23

Attachments:

• distcc.patch

[GoogleCodeExporter]

The patch looks good to me.

I've added you as a member of the distcc project on code.google.com,
so you can go ahead and commit it into the repository, if you want.

Original comment by fergus.h...@gmail.com on 21 Jan 2009 at 7:14

[GoogleCodeExporter]

Committed patch to SVN

Original comment by ads...@gmail.com on 22 Jan 2009 at 6:32

• Changed state: Started
• Added labels: Type-Defect, Priority-Medium, Usability

[GoogleCodeExporter]

Can we mark this one as fixed now?

Original comment by fergus.h...@gmail.com on 31 Jan 2009 at 9:54

• Changed state: Fixed

[GoogleCodeExporter]

Probably, though I think I may have missed some configure flags.  But it's 
fixed the
bugged problem.

Original comment by ads...@gmail.com on 1 Feb 2009 at 1:57

[GoogleCodeExporter]

As a followup to the 'known/suspected bugs' (sorry, wasn't sure whether I 
should open 
a new issue), the attached patch removes hosts that have duplicate service 
names.

So, e.g. my laptop that has both IPv4 and IPv6 addresses on both its wired and 
wireless interfaces, instead of showing up four times, only shows up once.

Original comment by benizi on 7 Apr 2009 at 7:46

Attachments:

• distcc-3.1-zeroconf-nodups.patch

[GoogleCodeExporter]

The deduplication patch needs more work, it should basically concatenate all 
ips reported for a host and then select one based on if it can actually reach 
it (route, ipv6 vs ipv4 etc)

While this might add support for avahi ipv6, but what about the "allow" masks?
How can you compile when --allow is mandatory?

Ie i can see my hosts but i can't connect to them due to acl rules?

Or have i missed a patch?

Original comment by Ian.Kuml...@gmail.com on 3 Oct 2010 at 9:09

[GoogleCodeExporter]

This aint fixed... not in Debian anyway.

Original comment by spy...@gmail.com on 23 Oct 2010 at 4:12

[GoogleCodeExporter]

Indeed it is not. Very annoying bug.

Original comment by bgam...@gmail.com on 5 Nov 2010 at 4:13

[GoogleCodeExporter]

As Comment 13 in Issue 42 points out, this bug was fixed in revision 650 and 
revision 673 but for some reason got left out of the 3.1 release. It is also 
missing from the current trunk. Perhaps someone did a poor job merging branches 
at some point and accidentally wiped out the fix?

In any case, since this issue is not getting any response here, I have 
submitted the patch that fixes this to Ubuntu. It is now available in oneiric 
as distcc_3.1-4ubuntu2:

https://bugs.launchpad.net/ubuntu/+source/distcc/+bug/809534/comments/3

Original comment by taylor.j...@gmail.com on 17 Jul 2011 at 4:53

[GoogleCodeExporter]

The bug was fixed *after* the release of distcc 3.1.
The lack of a time machine prevented the fix from being included in the distcc 
3.1 release :)
The bug is fixed at head and will be included in the next release of distcc.
The real problem here is that it's been a long time since the last release.
Must be time to do a new release soon...

Original comment by fergus.h...@gmail.com on 28 Jul 2011 at 10:12

[GoogleCodeExporter]

Yes it would be good to release, as many people have problems with ipv6 and 
duplicates hosts...

Original comment by bique.al...@gmail.com on 21 Oct 2011 at 9:47

[GoogleCodeExporter]

I built from trunk, (after trying the build packages, which happen to not be 
built with zeroconf support) and while zeroconf now works *some* of the time, 
it still doesn't work *all* of the time (intermittent during a long compile 
with same parse error)

This problem is not fixed.

Original comment by shawnlan...@gmail.com on 3 May 2012 at 7:57

[GoogleCodeExporter]

The patch was applied to head some time ago.
So if it is still not working reliably, another patch will be required.
I suggest you open a new bug for the new issue, and if you have a fix for it 
please attach the patch to the new bug.

Original comment by fergus.h...@gmail.com on 3 May 2012 at 9:15

[GoogleCodeExporter]

Issue 118 has been merged into this issue.

Original comment by mand...@gmail.com on 8 May 2013 at 12:18