Failed tests on make check (gentoo gcc-4.3.3)

[GoogleCodeExporter]

I ran into problems with "make check" before svn commit'ing for issue 43.  
It appears the DotD_Case.TempCompile_Case C++-specific tests fail under GCC 
4.3.3 (which tends to be more strict than GCC 4.1.2).  I've attached full 
output for the failed tests along with a patch that appears to fix it.  
(Will commit to SVN if it looks fine to you, then commit the patch for 
issue 43 afterward.)

$ cat test.cpp
int main(char **argv) {};

$ gcc-4.3.3 --version
gcc (Gentoo 4.3.3 p1.0, pie-10.1.5) 4.3.3
$ gcc-4.3.3 -c test.cpp -o /dev/null ; echo $?
test.cpp:1: error: first argument of ‘int main(char**)’ should be ‘int’
test.cpp:1: error: ‘int main(char**)’ takes only zero or two arguments
1
$

$ gcc-4.1.2 --version
gcc-4.1.2 (GCC) 4.1.2 (Gentoo 4.1.2 p1.0.2)
$ gcc-4.1.2 -c test.cpp -o /dev/null ; echo $?
0
$

Original issue reported on code.google.com by benizi on 8 Apr 2009 at 11:28

Attachments:

• distcc-testfail.patch
• distcc-dotd-failure.tar.bz2

[GoogleCodeExporter]

I suggest a slightly different fix: use

  int main(void) { return 0; }

That's less likely to have more problems in future.
I will make a patch with that slightly different fix and apply it.

Original comment by fergus.h...@gmail.com on 10 Apr 2009 at 4:48

[GoogleCodeExporter]

Fixed in SVN revision 665.

Original comment by fergus.h...@gmail.com on 14 Apr 2009 at 8:35

• Changed state: Fixed