include_server path in $prefix/bin/pump is missing a slash

[GoogleCodeExporter]

Run: ./configure --prefix=/tmp/distcc-foo && make && make install

Then look in /tmp/distcc-foo/bin/pump:
include_server='tmp/distcc-foo/lib/python2.4/site-packages/include_server/includ
e_server.py'

It's missing a '/' in front of tmp/.

In Makefile.in on the sed line in the install-include-server target, you
need to put a / in front of $$INCLUDE_SERVER.

Original issue reported on code.google.com by zhang...@gmail.com on 3 Jun 2008 at 10:25

[GoogleCodeExporter]

Hmm, I think it needs $$DESTDIR in front of $$INCLUDE_SERVER.  But this gets a 
bit
confusing: the behavior is determined by python's setup.py, not anything we do 
in
particular.

What happens if you set prefix to be a relative directory instead of an 
absolute? 
Does the code work properly?  I don't think adding a leading slash is right in 
that
case, though we'll have to explore what is.

Original comment by csilv...@gmail.com on 3 Jun 2008 at 11:00

• Changed state: Accepted

[GoogleCodeExporter]

> What happens if you set prefix to be a relative directory instead of an 
absolute?

You'll get an error from configure:

$ sh configure --prefix=whatever
configure: error: expected an absolute directory name for --prefix: whatever

So we don't need to worry about that case.

Original comment by fergus.h...@gmail.com on 3 Jun 2008 at 11:26

[GoogleCodeExporter]

This looks like it was a bug in setup.py.  We work around it now, as of svn 
commit 461.

Original comment by csilv...@gmail.com on 4 Jun 2008 at 5:18

• Changed state: Fixed