distcc 3.1 will not compile correctly with current version of gcc

[GoogleCodeExporter]

Version of distcc:  3.1

Platform and compilare:  Archlinux x86_64 and gcc (GCC) 4.6.0 20110603

Trying to do:  Build distcc from source

What went wrong: A make check fails with current gcc.  

One of the problems is the error message format was changed.

SyntaxError_Case               FAIL

AssertionError: string does not match regexp

   string: 'testtmp.c:1:1: error: unknown type name \xe2\x80\x98not\xe2\x80\x99\ntesttmp.c:1:7: error: expected \xe2\x80\x98=\xe2\x80\x99, \xe2\x80\x98,\xe2\x80\x99, \xe2\x80\x98;\xe2\x80\x99, \xe2\x80\x98asm\xe2\x80\x99 or \xe2\x80\x98__attribute__\xe2\x80\x99 before \xe2\x80\x98source\xe2\x80\x99\ntesttmp.c:1:7: error: unknown type name \xe2\x80\x98source\xe2\x80\x99\n'

   re: 'testtmp.c:1: .*error'

Full log files are attached.

Steps taken:
./configure --prefix=/usr --with-gtk --sysconfdir=/etc --mandir=/usr/share/man
make WERROR_CFLAGS= INCLUDESERVER_PYTHON=/usr/bin/python2
make WERROR_CFLAGS= INCLUDESERVER_PYTHON=/usr/bin/python2 check

Original issue reported on code.google.com by graysky%...@gtempaccount.com on 23 Jun 2011 at 3:31

Attachments:

• 01_configure.log
• 02_make.log
• 03_make-check.log

[GoogleCodeExporter]

The issue description is quite misleading. It doesn't fail to compile, though 
the tests fail.

The reason is that recent gcc (the same test failure can be reproduced with 
4.5.2 as well) prints not only the line of the syntax error (the number after 
the first colon) but also the character in that line (the number after the 
second colon).

Here's the suggested fix.

Original comment by madkinder on 27 Jun 2011 at 10:23

Attachments:

• recent_syntax_error_case.patch

[GoogleCodeExporter]

Also
CPlusPlus_Case                 FAIL
DotD_Case                      [TempCompile_Case FAIL]

Original comment by pupyk...@gmail.com on 28 Jun 2011 at 7:51

Attachments:

• log

[GoogleCodeExporter]

Thanks for the fix, madkinder.  I had the same patch in mind and I have applied 
your patch in svn revision 742.

For the other issue raised by pupyk...@gmail.com, try configuring with 
"--disable-Werror".

Original comment by fer...@google.com on 28 Jun 2011 at 8:20

[GoogleCodeExporter]

It looks like it does not help. I build it with:

build() {
  cd "${srcdir}/${pkgname}-${pkgver}"

  [ -f Makefile ] || ./configure --prefix=/usr \
              --with-gtk \
              --sysconfdir=/etc \
              --mandir=/usr/share/man \
              --disable-Werror
  patch -p1 <$srcdir/recent_syntax_error_case.patch
  make WERROR_CFLAGS= INCLUDESERVER_PYTHON=/usr/bin/python2
}

check() {
  cd "${srcdir}/${pkgname}-${pkgver}"
  make TEST_PYTHON=/usr/bin/python2 check
}

Original comment by pupyk...@gmail.com on 28 Jun 2011 at 10:42

[GoogleCodeExporter]

I've checked distcc-3.1 on Ubuntu Natty with gcc-4.5.2 and gcc-4.6.1. Both 
produce the same test failures as pupyk... reported. Pupyk... could you please 
try the trunk version? It gives no test failures to me.

Original comment by madkinder on 29 Jun 2011 at 8:41

[GoogleCodeExporter]

Based on madkinder's input, I think this is fixed at head.

Original comment by fergus.h...@gmail.com on 29 Jun 2011 at 9:09

• Changed state: Fixed