my-embark-preview needs some work.

minad / consult

:mag: consult.el - Consulting completing-read

GNU General Public License v3.0

1.25k stars 105 forks source link

my-embark-preview needs some work. #627

Closed harizvi closed 2 years ago

harizvi commented 2 years ago

In the wiki where my-embark-preview is defined, it used a function embark-default-action which has since been removed. Can you please provide replacement code?

See here: https://github.com/minad/consult/wiki#manual-preview-for-non-consult-commands-using-embark

minad commented 2 years ago

I think this code comes from Doom Emacs - checkout the Vertico module there. @iyefrat maintains this module, so he can probably help with this.

iyefrat commented 2 years ago

I've updated the wiki with the current version we have on doom, let me know if you have any issues with it

harizvi commented 2 years ago

Thanks for updating the wiki, @iyefrat. It will be helpful for others as well.

IIRC, the previous version of this function acted like a toggle to turn preview on. So as you moved up and down, it showed preview for prev and next entries. Is there a way to achieve that?