search

minad / corfu

:desert_island: corfu.el - COmpletion in Region FUnction
GNU General Public License v3.0
1.06k stars 42 forks source link

Add corfu-popup-location defcustom (above or below current line) #393

Closed jrblevin closed 6 months ago

jrblevin commented 7 months ago

When a completion backend proposes multi-line completions (e.g., codeium.el), the corfu popup (which appears below the point by default) covers the completion preview. This patch introduces a defcustom corfu-popup-location which allows the user to set a preference for the popup to appear above the current line if there is space available. This allows one to see both the completions and the preview in the case of a multi-line completion.

minad commented 7 months ago

Thanks. I would be happy to add an option for a preferred popup location. Did you sign the FSF papers, see https://github.com/minad/corfu#contributions?

jrblevin commented 7 months ago

Thanks. I would be happy to add an option for a preferred popup location. Did you sign the FSF papers, see https://github.com/minad/corfu#contributions?

I spent a while searching for how to file the papers, but came up short. Do you possibly have a link with instructions?

minad commented 7 months ago

I spent a while searching for how to file the papers, but came up short. Do you possibly have a link with instructions?

Take a look at the CONTRIBUTE file in the Emacs source. Please let me know how it goes and when the assignment is complete.

minad commented 6 months ago

@jrblevin Ping. Any news here?

minad commented 6 months ago

@jrblevin Please let me know if you plan to pick this up again.