search

minad / corfu

:desert_island: corfu.el - COmpletion in Region FUnction
GNU General Public License v3.0
1.06k stars 42 forks source link

Error when typing part of a command #403

Closed hankertrix closed 6 months ago

hankertrix commented 6 months ago

image

This happens when trying to type part of a command. It started happening after the commits on 23rd December.

abougouffa commented 6 months ago

@hankertrix I was about to open an issue related to this.

This behavior has been introduced after 9cebcfedca0ab165fcfc8a56acc2d2513a02b9e3. As a workaround, I'm using the commit before 8b5dbebea284a8b5b06bbd5dd20c3ce82c13cb1a, and it is working ok for me.

minad commented 6 months ago

Thanks for the report. Unfortunately I cannot reproduce this issue in my setup, so it may be caused by some other package, for example by evil-collection. Can you try without evil-collection, in case you use that? Please create a minimal recipe based on emacs -Q, such that we can narrow down the problem.

abougouffa commented 6 months ago

Thank you for the quick response @minad

In my case, it was evil-collection who caused the problem.

@hankertrix: for info, this fixed the issue for me:

;; Adapt `evil-collection-corfu' to the new `corfu--setup' signature (see github.com/minad/corfu/issues/403)
(with-eval-after-load 'evil-collection-corfu
  (advice-remove 'corfu--setup #'evil-normalize-keymaps)
  (advice-add 'corfu--setup :after (lambda (&rest _) (evil-normalize-keymaps))))
hankertrix commented 6 months ago

Thank you so much @abougouffa for the pull request to evil-collection and for the code to fix the issue!