minad / olelo

Wiki with git backend
MIT License
241 stars 44 forks source link

Commit bcafcc65 breaks html rendering: <link>bla</link> #28

Closed marvin2k closed 14 years ago

marvin2k commented 14 years ago

With bcafcc653835522551c1ae889823d3ad98e1ea62, on my machine (using nokogiri (1.4.3.1)) in the head of a page the closing /link-statement is missing:

|link href="/static/images/favicon.png?1" rel="shortcut icon" type="image/png"|

where the pipes "|" should be <>... how can I escape these silly thing... anyway... there should be a line like

|link href="/static/images/favicon.png?1" rel="shortcut icon" type="image/png"||/link|

which is generated using 69040d875bfdaba0d35059100206e3f14a97f0f1

Reverting the commit solves the problem...

minad commented 14 years ago

The generated xhtml is correct on my installation. This issue is connected to issue #25.

tg-x commented 14 years ago

on my installation the doctype says html not xhtml and the link tags are not closed either, but iirc that's valid in html but not in xhtml

minad commented 14 years ago

The doctype should be xhtml. The problem lies in the switching between html/xhtml. I use the html parser because of the entities. This seems to be stupid. I thought if I use the html parser, that I get a relaxed xml parser which generates valid xhtml via to_xhtml (in helper.rb).

tg-x commented 14 years ago

maybe try with different ParseOptions?

minad commented 14 years ago

please try the xmlentries branch

marvin2k commented 14 years ago

hm, no change, same error in firefox. using opera, an error is given too, but an option is presented to render the page as "html", which works then...

minad commented 14 years ago

seems to be a broken libxml version. please confirm:

http://github.com/minad/olelo/commit/6ee25db8d754e75de04781377d835986b54b30f8

marvin2k commented 14 years ago

japp, the error is thrown... local version of libxml2 is 2.6.32.dfsg-5+lenny1 -- thanks for researching, will try to get an update

marvin2k commented 14 years ago

fixed with libxml2 2.7.7.dfsg-4