minad / olelo

Wiki with git backend
MIT License
241 stars 44 forks source link

XML Parsing Error #7

Closed ghost closed 14 years ago

ghost commented 14 years ago

It was easy to get up an running, but when I went to save my first edit I got this:

XML Parsing Error: not well-formed
Location: http://0.0.0.0:9292/
Line Number 1, Column 113:git log '--format=tformat:%H%n%P%n%T%n%an%n%ae%n%at%n%cn%n%ce%n%ct%n%x00%s%n%b%x00' '-1' 2>&1: fatal: unrecognized argument: --format=tformat:%H%n%P%n%T%n%an%n%ae%n%at%n%cn%n%ce%n%ct%n%x00%s%n%b%x00
----------------------------------------------------------------------------------------------------------------^
minad commented 14 years ago

There seems to be a problem with your git version because it doesn't seem to recognize the --format command line option. I commited a fix to escape the error message correctly.

minad commented 14 years ago

Could you take a look into the manuals of your git version? Maybe there is an alternative for this command with an backward compatible command line option. My git version is 1.6.4.4 btw.

minad commented 14 years ago

The newest gitrb gem version 0.0.8 should fix this. Please confirm!

minad commented 14 years ago

Fixed by minad/gitrb@8369c898c0f2dd78db2fd01fc38d535703c7bbce

ghost commented 14 years ago

Yep, that did the trick. If you don't mind me asking. Why didn't you use grit, since that is used by a commercial site (GitHub) you know it's going to be solid.

ghost commented 14 years ago

Oh, and thanks!

minad commented 14 years ago

At first I used ruby-git, which was abandoned in favor of grit. I missed some features in grit (initializing a repository for example) and I wanted a smaller and simpler library. Grit uses an abstraction to either use the git binary or doing the stuff in native ruby.