minad / olelo

Wiki with git backend
MIT License
241 stars 44 forks source link

s5 aspect not working #93

Open candlerb opened 10 years ago

candlerb commented 10 years ago

I have been trying to get the s5 aspect working in the 0.9.15 gem.

First thing was to symlink plugins/filters/s5/ui to a checkout of diascope

cd
git checkout git://github.com/minad/diascope.git
sudo mv diascope /usr/local/share/
sudo ln -s /usr/local/share/diascope/ui /var/lib/gems/1.9.1/gems/olelo-0.9.15/plugins/filters/s5/ui

After this the s5 aspect is available, but it doesn't render properly. Looking at the logs, the page is asking for e.g.

/_/assets/filter/s5/ui/common/jquery.js whereas it should be /_/assets/filters/s5/ui/common/jquery.js (note: filters not filter)

So I tried making what I thought was the obvious fix:

--- plugins/filters/s5/main.rb.orig     2013-08-29 23:39:41.642937172 +0100
+++ plugins/filters/s5/main.rb  2013-08-29 23:40:01.226936167 +0100
@@ -27,7 +27,7 @@
     themes.delete('default')
     themes.unshift(context.page.attributes['theme'] || 'default')
     super.merge(context.page.attributes['s5'] || {}).
-      merge('themes' => themes.join(' '), 's5_path' => build_path('_/assets/filter/s5'))
+      merge('themes' => themes.join(' '), 's5_path' => build_path('_/assets/filters/s5'))
   end
 end

However even after a server restart, I see requests for /assets/filter/s5. Something is cached somewhere. In fact, if I edit plugins/filters/s5/main.rb and put some debugging in, I don't think S5#params is being called at all.

I'm a bit lost now as to where the problem is.

Also: at http://www.gitwiki.org/Tests/Slideshow I note the comment "Still some stuff to fix here" which suggests there is some underlying issue...

candlerb commented 10 years ago

Using a git checkout of olelo, plus git submodule init && git submodule update to pull in diascope, plus applying the patch above, rendering Markdown as S5 appears to be working. (I have also set production: false)

minad commented 10 years ago

Content preview: Yes it works in the checked out version. However the diascope implementation of S5 is quite old and now there a lot better systems available than S5. Therefore I didn't invest much time to improve that. Maybe you have time to work on that? [...]

Content analysis details: (-2.9 points, 5.0 required)

pts rule name description


0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: github.com] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000]

Yes it works in the checked out version. However the diascope implementation of S5 is quite old and now there a lot better systems available than S5. Therefore I didn't invest much time to improve that. Maybe you have time to work on that?

See also the list of presentation frameworks at

What is your opinion about that?

Using a git checkout of olelo, plus git submodule init && git submodule update to pull in diascope, plus applying the patch above, rendering Markdown as S5 appears to be working.

Reply to this email directly or view it on GitHub [1].

Links:

[1] https://github.com/minad/olelo/issues/93#issuecomment-23592935

candlerb commented 10 years ago

The simple fix is at https://github.com/candlerb/olelo/tree/candlerb/s5_fix

I don't have time to work on diascope, it would probably be better to modify olelo to work with some of the newer JS presentation frameworks like reveal.js. (pandoc supports five of them: s5, slidy, slideous, dzslides, reveal)

minad commented 10 years ago

No I want to modify olelo exactly in such a way to support the different backends. We could also use the pandoc backend more heavily.