minad / olelo

Wiki with git backend
MIT License
241 stars 44 forks source link

Protocols Are Not Scheme-Neutral #96

Open tomrittervg opened 10 years ago

tomrittervg commented 10 years ago

I have Olelo installed and access it over HTTPS. The initial redirect sends me to /new - but this redirect happens over HTTP, and I leave HTTPS.

I can specify a root with 'base_path' but I cannot specify a scheme for redirects to favor. Better yet, automatically detect the scheme and keep the user on the same scheme.

tomrittervg commented 10 years ago

I figured out that my deployment was not what you had in mind. I have it sitting behind a reverse proxy that talks to it over HTTP, so it (reasonably) concludes it should keep everything HTTP. It would be nice to have a switch in the config so this can be done without performing ugly hacks.

minad commented 10 years ago

Would you provide a patch?

samba commented 10 years ago

@tomrittervg I have mine operating behind an Nginx proxy that enforces SSL, and appears to be working in this regard. You can see a (redacted) configuration here: http://paste.debian.net/hidden/088dad59/

Mine does have other issues as in #98 though.