search

minad / org-modern

:unicorn: Modern Org Style
GNU General Public License v3.0
1.54k stars 48 forks source link

COMMENT keyword not being prettified #179

Closed LemonBreezes closed 8 months ago

LemonBreezes commented 8 months ago

Hi. The COMMENT keyword just gets the org-special-keyword face and no prettification from this package. :(

minad commented 8 months ago

I don't see this, #+comment: ... gets prettified correctly on my side. Can you reproduce this in a minimal setup starting from emacs -Q?

LemonBreezes commented 8 months ago

I don't see this, #+comment: ... gets prettified correctly on my side. Can you reproduce this in a minimal setup starting from emacs -Q?

Nonono, I meant like this image

I'm thinking it can look similar to how dates look: image

minad commented 8 months ago

Okay, I see. You would like to have a style similar to dates or TODO keywords? I don't think we need a special style for this one, but I am not opposed to adding this if someone propose a good PR. Are there other such special headline keywords we could support? (EDIT: I checked the org.el source and it seems COMMENT is the only special keyword. Tbh given that COMMENT is a special case, I find it a bit out of proportion to add extra support to Org-modern.)

Generally please take more care when creating issues or feature requests, since I cannot understand what you mean otherwise.

minad commented 8 months ago

@LemonBreezes Btw, I usually use the :noexport: tag if I want to prevent exporting some headlines. Do you know if COMMENT offers any advantages over using such a tag?

LemonBreezes commented 8 months ago

@LemonBreezes Btw, I usually use the :noexport: tag if I want to prevent exporting some headlines. Do you know if COMMENT offers any advantages over using such a tag?

I don't know to be honest. It seems purely aesthetic, though I never knew about :noexport:. I just basically spent the hours preparing this bug report for Org mode https://lists.gnu.org/archive/html/emacs-orgmode/2024-03/msg00037.html so that I can get the special keywords and dates to not overwrite the heading backgrounds: image image

Sorry for not being detailed in the issues, it's basically just me being lazy.

minad commented 8 months ago

I don't know to be honest. It seems purely aesthetic, though I never knew about :noexport:.

For me the advantage of :noexport: is that it reuses tags. It doesn't seem justified to introduce special syntax only for this. Therefore I also don't see the need to add special support here.

Sorry for not being detailed in the issues, it's basically just me being lazy.

Please take it into account for the future. This helps avoiding some back and forth.