search

minad / vertico

:dizzy: vertico.el - VERTical Interactive COmpletion
GNU General Public License v3.0
1.49k stars 60 forks source link

Deprecating Selectrum in favor of Vertico #237

Closed raxod502 closed 1 year ago

raxod502 commented 2 years ago

Hey @minad, per https://github.com/radian-software/selectrum/issues/598#issuecomment-1121682815 I'm investigating what's needed to deprecate Selectrum in favor of Vertico. Mostly, this means making sure Vertico has feature parity with Selectrum. I figured there would probably be a bit of discussion necessary on a variety of topics, so I opened this issue to have a single place for those.

My first question is about faces used by Vertico. Vertico defines four faces of its own (vertico-multiline, vertico-group-title, vertico-group-separator, vertico-current) but it appears that other faces are used as well, at least by default. I presume these faces come from the default Emacs completion system. For example, here is a dark blue face I'm seeing (with zerodark-theme):

image

Which doesn't match any of Vertico's faces:

image

Is there a list of the faces that will end up in the minibuffer by default with Vertico, so that users know what they have to customize in order to change the appearance?

ashton314 commented 1 year ago

If I may interject for a moment, I'd like to convey my sincere thanks to @raxod502 and @minad for your contributions to Emacs. Selectrum taught me to love lightweight packages, and Vertico just added onto that. So thank you, both of you.