minamarkham / yonce

👑 Queen Bey-inspired themes for all your favs.
http://yoncetheme.com
MIT License
333 stars 33 forks source link

Patching Dank Mono as a Nerd Font is not sufficient to render this theme correctly. #8

Open krotondo opened 5 years ago

krotondo commented 5 years ago

I installed bash-it, bought Dank Mono and patched it using Nerd Fonts. However, after changing the Basic theme in Terminal to use this font, some characters are rendering as question marks:

 Always stay gracious, best revenge is your paper ┌ kate   Kates-MacBook-Pro   ~
└

The character before the ~ is rendering properly as a file folder, but the crown, person, computer, and >> all render as [?]. When I switch the font to the unpatched version, the file folder also doesn't render.

I tried switching to a patched font that ships with Nerd Fonts (Hack Nerd Font), and the characters all appear properly.

I set the font back to Dank Mono Nerd Font and restarted Terminal, but the problem persisted with Dank Mono Nerd Font.

I had patched the fonts using the following command, on both the ttf and otf versions, both regular and italic, before installing them in Font Book.

./font-patcher ~/Downloads/DankMono-491/ttf/DankMono-Regular.ttf

Are there additional required arguments or steps to patch the font?

mloberg commented 5 years ago

Nerd Fonts doesn't add glyphs automatically, you either need to specify which glyphs to add or use the --complete option to use them all. I would also recommend the -s option to make the glyphs mono.

Zethtren commented 1 year ago

@mloberg "-s" If I found this comment 2 hours sooner I would have samed so much headache...