search

minamijoyo / tfupdate

Update version constraints in your Terraform configurations
MIT License
542 stars 23 forks source link

Pre commit hooks #63

Closed jrottenberg closed 2 years ago

jrottenberg commented 2 years ago

Allow users to leverage tfupdate via pre-commit.

minamijoyo commented 2 years ago

@jrottenberg Thank you for your suggestion, but I prefer to keep a pull request for dependency changes made by tfupdate separate from other changes so that reviewers can easily confirm the changes. So I recommend users to use tfupdate in CI/CD pipeline and I don't encourage users to use tfupdate in a pre-commit hook.

Having said that, I understand there are various ways of thinking, it's ok that you use tfupdate in a pre-commit hook as you like, of course! I guess the best place to share your configuration is: https://github.com/antonbabenko/pre-commit-terraform Wouldn't it be better to share your configuration with people who like pre-commit hooks rather than putting it in this repository?

jrottenberg commented 2 years ago

That's very nice, much appreciated.

All good I'll send the PR to Anton Babenko.

Thank you for a great project in the terraform ecosystem.

jrottenberg commented 2 years ago

It has been merged in the pre-commit terraform repo 🎉

https://github.com/antonbabenko/pre-commit-terraform/pull/342

Hopefully get more users adopting this great tool !