search

minaskar / zeus

⚡️ zeus: Lightning Fast MCMC ⚡️
https://zeus-mcmc.readthedocs.io/
GNU General Public License v3.0
225 stars 34 forks source link

Remove error suppression by ChainManager in case of pickling failure #24

Closed ewoudwempe closed 2 years ago

ewoudwempe commented 2 years ago

Hi, thanks for this great sampler! I was having trouble getting my sampling to work with MPI, everything seemed to run fine, but I got no output. The reason was that my likelihood function was unpickleable, but that was a bit hard to track down, because the pickling errors were suppressed by the ChainManager. So here is a PR to no longer suppress these exceptions. Or if there is a good reason for it, or a better solution, then feel free to close this.

minaskar commented 2 years ago

That looks good, I'm merging the pr.

Thanks