minaskar / zeus

⚡️ zeus: Lightning Fast MCMC ⚡️
https://zeus-mcmc.readthedocs.io/
GNU General Public License v3.0
225 stars 34 forks source link

pip version does not have EnsembleSampler #6

Closed AdityaSavara closed 3 years ago

AdityaSavara commented 3 years ago

I used a pip install. Then tried to follow the example here: https://zeus-mcmc.readthedocs.io/en/latest/

It didn't work. But changing EnsembleSampler to sampler worked.

minaskar commented 3 years ago

Thank you for raising this issue with us.

I'm in the process of updating the docs for some new features that I'll release in the next couple of days. Keep an eye for the new Moves Interface. In the meantime, the sampler class should work with no issues.

All the best, Minas

AdityaSavara commented 3 years ago

Great. One thing to note is that threeML is also using the variable name "sampler" : https://github.com/threeML/threeML/blob/master/threeML/bayesian/zeus_sampler.py

You may want to consider simply having sampler = EnxembleSampler in your code to maintain backwards compabitibility.

minaskar commented 3 years ago

I will do that! Thank you very much!