search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.93k stars 701 forks source link

side mouse butons doesnot work after (right click) -> View Image #1013

Open shalva97 opened 4 years ago

shalva97 commented 4 years ago

Just what the title says. but UI buttons work fine.

PalmerAL commented 4 years ago

Linux or Windows?

shalva97 commented 4 years ago

Linux

shalva97 commented 4 years ago

same problem happens if i change the website in the current tab

Syndamia commented 4 years ago

@shalva97 are you still having this issue?

If so, would mind sharing what functions these buttons have assigned and your linux distribution?

shalva97 commented 4 years ago

just pulled Master and it exactly same

so here is my setup as xev says:

Button 9 is forward

ButtonPress event, serial 40, synthetic NO, window 0x4800001,
    root 0x19f, subw 0x0, time 46724133, (102,116), root:(102,145),
    state 0x0, button 9, same_screen YES

ButtonRelease event, serial 40, synthetic NO, window 0x4800001,
    root 0x19f, subw 0x0, time 46724309, (102,116), root:(102,145),
    state 0x0, button 9, same_screen YES

and Button 8 is back

ButtonPress event, serial 40, synthetic NO, window 0x4800001,         [33/2882]
    root 0x19f, subw 0x0, time 46874117, (160,154), root:(160,183),
    state 0x0, button 8, same_screen YES

ButtonRelease event, serial 40, synthetic NO, window 0x4800001,
    root 0x19f, subw 0x0, time 46874205, (160,154), root:(160,183),
    state 0x0, button 8, same_screen YES

xdotool equivalent:

#!/usr/bin/fish

sleep 1
xdotool click 8
PalmerAL commented 4 years ago

This is a regression from 4a0c243664c66022187cf7181e9c799e6ed73437; Electron (or maybe Chromium?) apparently handles the mouse button events on regular webpages, but not images. Ideally, this would be fixed there, but if that's not feasible we would need to send an IPC message to the UI process, check if the tab URL is an image, and then only navigate if it is.