Ctrl+num doesn't change to tab num

minbrowser / min

A fast, minimal browser that protects your privacy

https://minbrowser.org/

Apache License 2.0

7.99k stars 709 forks source link

Ctrl+num doesn't change to tab num #1239

Open kodumbeats opened 4 years ago

kodumbeats commented 4 years ago

Min Version: Min v1.16.0, Chromium v83.0.4103.122
Operating system: Manjaro Linux

Expected Behavior

Ctrl+x changes to tab x as described in https://github.com/minbrowser/min/blob/master/js/defaultKeybindings.js#L96

Actual Behavior

Tabs change in an unusual way, and I couldn't find a pattern.

To Reproduce

Open multiple, random browser tabs
Press Ctrl+1 to attempt to switch to first tab, Ctrl+2, and so on.

PalmerAL commented 4 years ago

The way it works is that ctrl+1 moves one tab right, ctrl+2 moves 2 tabs right, etc. shift+ctrl+n moves n tabs to the left.

I think this works a lot better when you have more than 10 tabs open, but I can also see how it would be confusing coming from another browser that doesn't do that; it might make sense to add a preference for this.

alswl commented 6 months ago

A simple patch serves as a temporary solution for this case. https://github.com/minbrowser/min/commit/0524fe6f843b1f65660fef67d3dd7f3fbd3dd246

Now I provided pre-build package, https://github.com/alswl/min/releases

This is primary pull request https://github.com/alswl/min/pull/2 .

alswl commented 4 months ago

@PalmerAL I can provide pull-request for this features, is it welcome?