search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.86k stars 696 forks source link

Store dirs "Cache" and "Code Cache" in $XDG_RUNTIME_DIR/.cache/Min #1600

Open eleksir opened 3 years ago

eleksir commented 3 years ago

Min uses $XDG_CONFIG_HOME/Min for this purpose, but most chrome-like browsers use $XDG_RUNTIME_DIR/.cache/application_name to avoid unnecessary disk thrashing.

$XDG_RUNTIME_DIR in many linux distributions points somwhere to /run/user/$(id -u) and in most distributions /run mounted as tmpfs.

eleksir commented 3 years ago

There is also set of same dirs in $XDG_CONFIG_HOME/Min/Partitions/webcontent/Cache $XDG_CONFIG_HOME/Min/Partitions/webcontent/Code Cache

I don't quite understand what for? But it looks like they also should be in $XDG_RUNTIME_DIR/.cache/Min

PalmerAL commented 3 years ago

See https://github.com/electron/electron/issues/8124 and the proposed fix: https://github.com/electron/electron/pull/19693

I think the current summary of the situation is here: https://github.com/electron/electron/pull/19693#pullrequestreview-584007491

I think this was originally a Chromium design decision that we inherited, so I'm not sure what other Chromium browsers are doing differently here. Using the standard cache directory does seem like a better choice, but I don't think we can do anything here until Electron decides what to do.