minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.84k stars 695 forks source link

1Password not working #2151

Open lpossamai opened 1 year ago

lpossamai commented 1 year ago

Hi there! :)

I'm back at using Min, but when I installed it again it picked up my last settings. Is there a way to clean up everything and start with a fresh install?

The reason I ask that is because I'm facing the same issue again (https://github.com/minbrowser/min/issues/1981) and also the tabs are funny... so I wanna try cleaning up. Screenshot 2022-12-21 at 6 12 52 PM

Thanks in advance! Lucas

PalmerAL commented 1 year ago

Hey! Deleting ~/Library/Application Support/Minshould work.

the tabs are funny

It looks like the "use separate title bar" preference broke on macOS at some point; try disabling that.

lpossamai commented 1 year ago

It looks like the "use separate title bar" preference broke on macOS at some point; try disabling that.

Thanks, that worked!

About 1Password - It's not showing up autofill, only if I press CMD+\ I can see the credentials. Is this a normal behavior?

❯ op --version
2.2.0
lpossamai commented 1 year ago

FYI - This is the error I get when trying to use 1password (during the authentication part)

counts found matching filter "min-autofill"
, null, undefined, 1
    at onmessage (processWorker.js:16:13)
bundle.js:11706 Error accessing 1Password CLI.  Error: Process terminated: [ERROR] 2022/12/22 13:22:57 no accounts found matching filter "min-autofill"
, null, undefined, 1 Error: Process terminated: [ERROR] 2022/12/22 13:22:57 no accounts found matching filter "min-autofill"
, null, undefined, 1

Screenshot 2022-12-22 at 1 24 49 PM

PalmerAL commented 1 year ago

About 1Password - It's not showing up autofill, only if I press CMD+\ I can see the credentials. Is this a normal behavior?

I think this is expected, yes.

FYI - This is the error I get when trying to use 1password (during the authentication part)

When is this error happening? Since you say you do see credentials being shown, I don't understand what's not working.

lpossamai commented 1 year ago

Sorry for the delay on getting back to you! I was away on holidays.

About 1Password - It's not showing up autofill, only if I press CMD+\ I can see the credentials. Is this a normal behavior?

I think this is expected, yes.

Hmm are you sure? When clicking on that key lock shouldn't it display the options for the website I'm in? Screenshot 2023-01-08 at 10 18 12 PM

Like this example (on Firefox)? Screenshot 2023-01-08 at 10 20 28 PM

FYI - This is the error I get when trying to use 1password (during the authentication part)

When is this error happening? Since you say you do see credentials being shown, I don't understand what's not working.

Sorry, I should've explained better!

When I click on the key lock, Min asks for my 1Password password, email address and secret key. I type the information and press OK, but I get taken back to the same screen below: Screenshot 2023-01-08 at 10 23 06 PM

Yes, using 1Password with CMD + \ works, but the above happens anyways.

lpossamai commented 1 year ago

Same issue as previously reported here https://github.com/minbrowser/min/issues/1981

sppfly commented 9 months ago

I met the same issue on Fedora 39

tconroy commented 8 months ago

Encountering similar issues trying to use 1Password on MacOS.

After entering my credentials when prompted (email/pass/secret key), the prompt just kept re-appearing.

Force-quitting Min and reopening it showed that 1Password was now selected in preferences, and I see the key icon in login inputs, however when I click the key, I am prompted to enter my 1Password master pass. When I do, then the email/pass/secret key prompt starts appearing.

After a while this error was shown: Screen Capture 2023-12-24 at 15 22 15@2x

tconroy commented 8 months ago

Here is a video of what I am seeing:

https://github.com/minbrowser/min/assets/1609336/2c3492e4-66cd-4924-88f0-168aa7fc942b

PalmerAL commented 8 months ago

@sppfly @tconroy:

tconroy commented 8 months ago

@PalmerAL:

If you run op -v in the terminal, what version do you have installed?

❯ op -v
2.24.0

Does your account have 2FA? Does it have a custom domain (something other than my.1password.com)? Do you have biometric unlock turned on (https://github.com/minbrowser/min/issues/1981#issuecomment-1160673942)?

2FA is enabled. It does not have a custom domain. I believe biometric unlock is enabled (I get touchId prompt when unlocking 1PW in the browser etc), however my "developers" tab looks different with no specific call-out to the CLI: Screen Capture 2023-12-26 at 16 33 44@2x

If you delete ~/.config/op, and restart Min, does that help?

Unfortunately this did not help. The below files were removed, however I was still in the infinite loop shown here, requiring me to force-quit min.

❯ rm -rf ~/.config/op
/Users/me/.config/op/config
/Users/me/.config/op/op-daemon.sock
/Users/me/.config/op
PalmerAL commented 8 months ago

I think this "Integrate with 1Password CLI" setting is the problem. If I leave that off, it works, even with the latest version of the CLI. If I turn that on, it seems to disable signin for accounts configured from the CLI:

op signin --raw --account min-autofill
[ERROR] 2023/12/29 21:23:59 found no accounts for filter "min-autofill"

Can you try turning that off and see if it works?

Also, do you recall if you turned this on previously? It was turned off for me by default, but I'm wondering if it was turned on automatically for you.

tconroy commented 8 months ago

Hey @PalmerAL,

so disabling "Integrate with 1Password CLI" did fix that infinite loop issue -- now, I enter my login credentials once, and it seemed to log-in successfully (got a "new sign-in" email from 1PW). Progress! 🎉

However, I'm not able to view my credentials / auto-fill via 1PW. Clicking on the key icon seems to do nothing. Opening dev tools for the browser, I didn't observe any errors being thrown:

https://github.com/minbrowser/min/assets/1609336/fbb35a15-2f46-4b53-8ba1-5f05ae84c9d5

PalmerAL commented 8 months ago

If you haven't restarted Min already, could you try doing that? Does this also happen on other websites?

mentionmenot commented 8 months ago

Hey @PalmerAL,

so disabling "Integrate with 1Password CLI" did fix that infinite loop issue -- now, I enter my login credentials once, and it seemed to log-in successfully (got a "new sign-in" email from 1PW). Progress! 🎉

However, I'm not able to view my credentials / auto-fill via 1PW. Clicking on the key icon seems to do nothing. Opening dev tools for the browser, I didn't observe any errors being thrown: Screen.Capture.2023-12-30.at.13.36.10.mp4

I have exact this issue on my Mac. Looks like me and some other people are having this problem. https://github.com/minbrowser/min/issues/1626

tconroy commented 8 months ago

@PalmerAL :

If you haven't restarted Min already, could you try doing that? Does this also happen on other websites?

I did restart Min a few times. No change. Interestingly, I am not seeing the autofill icon (key) appear on other sites. The icon is present on github login, but is missing on gmail, twitter, hacker news, reddit, etc. The icon just isn't there so I haven't been able to confirm if it works on other sites or not unfortunately 😞 Not sure why it shows for GitHub but not others

@mentionmenot: Thanks! Maybe we should merge these issues to combine focus?

PalmerAL commented 8 months ago

@tconroy @mentionmenot If you have time, would you be willing to check if your 1password installation is working correctly?

export OP_DEVICE="paste the device ID here"
op signin --raw --account min-autofill

Then copy the resulting key (in my case, there's a final % character displayed that needs to be removed), and paste it into this command:

op item list --categories login --session="paste value here" --format=json

Do you get results? Is one of those results a Github login?


Also:

tconroy commented 8 months ago

Hey @PalmerAL!

first off just want to say thank you for your continued help on this!

What version of macOS is this?

MacOS Sonoma, 14.2.1

If you open the page devtools (right-click > inspect element) and then click on the key, are there any errors?

No errors appearing in console when loading the page or clicking the key icon.


for the op signin stuff, a few interesting things happened. I'll share the raw terminal output here:

❯ export OP_DEVICE="<my actual device key here>"
❯ op signin --raw --account min-autofill
Would you like to turn on the 1Password app integration? This allows you to sign in to 1Password CLI using the 1Password app. [Y/n] Y
Unlock 1Password and select 'Integrate with 1Password CLI' in the Settings window that opens. To use Touch ID, Windows Hello, or another system authentication option with 1Password CLI, navigate to the Security tab and turn it on.
Waiting for setting to change. To cancel, enter Ctrl + C.
All set! Let's 🚀
[ERROR] 2024/01/04 11:46:29 found no accounts for filter "min-autofill"

❯ op signin --raw --account min-autofill
[ERROR] 2024/01/04 11:46:34 found no accounts for filter "min-autofill"

So this is interesting.. It made me re-enable the setting we previously disabled ("integrate with 1Password CLI"). After doing so, the command failed with found no accounts for filter "min-autofill".


EDIT: I just tried again, this time disabling the 1PW CLI integration / choosing "n" at the prompt. This got me through the commands you listed.

I am seeing a big json dump of my accounts. Grepping through it I did find my github login.

PalmerAL commented 8 months ago

Thanks! That's useful.

If you have a chance to test it, I have a branch here that will auto-skip the "Would you like..." prompt: https://github.com/minbrowser/min/tree/1password-fixes-2151. I believe autofill should work after this point.

For users that have the integration enabled from the 1password app already, this will still fail; we'll need to add a note in the documentation about that (or possibly detect it and handle it; I think it should be possible to support, but would need an alternative implementation).

I also fixed the autofill icon not appearing on Google and HN. Twitter and Reddit will require more work to get working.