minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.75k stars 689 forks source link

Cannot print PDF documents directly from Min PDF viewer #2220

Closed devgocri closed 1 year ago

devgocri commented 1 year ago

Expected Behavior

When having a PDF document open in Min and the key combination Command+p is pressed or the print option is selected from the title bar, a print dialogue should open which will allow the user to then print the document out, similar to the behaviour of attempting to print web pages.

Actual Behavior

Upon request to print the document, instead of carrying out the expected behaviour outlined above, Min resizes the content of the PDF within the PDF viewer (as demonstrated in attached images), and does not open the system's print dialogue. The PDF preview within Min can be restored by refreshing the page.

Before requesting to print the file:

image

After requesting to print the file:

image

To Reproduce

  1. Open a PDF file in Min Browser.
  2. Try to print the file from inside Min Browser's PDF viewer.
devgocri commented 1 year ago

Forgot to mention: The page's DevTools console gives this error.

pdf_viewer.js:3996 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'style')
    at PDFPageView.cssTransform (pdf_viewer.js:3996:12)
    at viewer.js:594:28
    at viewer.js:418:15
PalmerAL commented 1 year ago

Fixed, thanks for reporting this.