search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.9k stars 703 forks source link

feat(bitwarden): added field for server url during setup for self-hosted servers and others #2246

Open UnKnoWn-Consortium opened 1 year ago

UnKnoWn-Consortium commented 1 year ago

feat(bitwarden): added field for server url during setup for self-hosted servers fix(bitwarden): fixed confusing cache logic that does not cache credential request responses properly refactor(prompt): retrofitted the createPrompt function with promise refactor(prompt): updated createPrompt usage for the promise retrofit refactor: unwrapped AutofillSetup as individual functions and exported the initialize function that is used externally refactor: unwrapped PasswordManagers as individual functions and exported functions that are used externally refactor: replaced some usages of var with let and const

PalmerAL commented 1 year ago

This seems reasonable from reading over it; can you explain "fixed confusing cache logic that does not cache credential request responses properly"?

UnKnoWn-Consortium commented 1 year ago

@PalmerAL In the original code, the cache list lastCallList for a domain is set to a promise instead of the suggestion returned from the password manager. https://github.com/minbrowser/min/blob/5bd1544eb1bbd4ea7913d25da26f4395bc177d85/js/passwordManager/bitwarden.js#L87

UnKnoWn-Consortium commented 1 year ago

@PalmerAL Thanks for bringing us multi-window support. I will resolve the conflict asap. Done.

UnKnoWn-Consortium commented 1 year ago

@PalmerAL Sorry to ping. Conflict resolved now.

PalmerAL commented 1 year ago

Sorry, I haven't had time to test this. Will do in the next few days.

UnKnoWn-Consortium commented 1 year ago

@PalmerAL Sorry my fault. Please take your time.