search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.72k stars 685 forks source link

The color of the tab does not match the color set by the site. #2248

Open xlebpushek opened 1 year ago

xlebpushek commented 1 year ago

Expected Behavior

The color of the current tab must exactly match the specified color value in the meta tag of the site when using the colors of the tabs of the current site.

Actual Behavior

At the moment, when setting the color #ffffff or the corresponding rgb(255,255,255) for the meta tag "theme-color" of my site, do I get the color of the tab #999999, what can be seen on the screenshot. image A similar situation occurs with any site. The color of the tabs of absolutely all sites where the meta tag "theme-color" is used are actually darkened. The exception is sites where the value of this meta tag is equal to: #000000 or rgb(0,0,0), respectively.

Please fix it.. I've been suffering watching this for a year now.

PalmerAL commented 1 year ago

Hm, the colors are intentionally darkened when you have dark mode enabled. Do you think this is an issue on all sites, or just ones where the site explicitly sets a color with the meta tag? We could make this a separate preference from light/dark mode, or we could darken favicon colors but leave the ones set with the meta tag the same.

xlebpushek commented 1 year ago

Hm, the colors are intentionally darkened when you have dark mode enabled. Do you think this is an issue on all sites, or just ones where the site explicitly sets a color with the meta tag? We could make this a separate preference from light/dark mode, or we could darken favicon colors but leave the ones set with the meta tag the same.

It seems to me that the best option would be to make a separate option in the browser settings, when enabled, the tabs will be darkened regardless of which theme is currently enabled. And if the option is disabled, the colors will remain original.

I'm actually hoping to fix this. For me, the min browser has become the best browser. But this misunderstanding hinders me as a designer and developer.

Speaking of individual settings, the contrast of the active tab could also be made into a separate option, but this is another topic.

xlebpushek commented 1 year ago

I remind you that in version 1.28.0-beta my problem was not solved ..