search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.72k stars 685 forks source link

Remove "#pdfjs.action=download" #2285

Closed Sestowner closed 11 months ago

Sestowner commented 11 months ago

URLs that contain "#pdfjs.action=download" was opening Electron's built-in pdf viewer.

To reproduce, open https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf#pdfjs.action=download

This also fixes #2208.

PalmerAL commented 11 months ago

Looks good, thanks!

(I was wondering why the download button in the viewer still works with this change. The reason is that the request made when clicking that has details.resourceType: 'other').