search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.9k stars 701 forks source link

Finder access when downloading a file #2322

Closed M-Arnone closed 12 months ago

M-Arnone commented 1 year ago

Expected Behavior

Display the file in the repo where it is

Actual Behavior

Button crashes Finder app

To Reproduce

  1. Download a file
  2. Click on this button (view picture) SCR-20230926-iwgr
iambudi commented 1 year ago

On MacOS Sonoma, i could not even see the whole download bar in the bottom. Should we add an additioanal menu to show the download history?

M-Arnone commented 1 year ago

On MacOS Sonoma, i could not even see the whole download bar in the bottom. Should we add an additioanal menu to show the download history?

Why not but first, let's fix for those who sees the download. I downloaded Sonoma but get back to Ventura, Sonoma is too bugged this day.

PalmerAL commented 12 months ago

Fixed in 1180df5690488608e179d0a6380c408a77f06416, thanks for reporting.

@iambudi Can you add a screenshot in a new issue?

M-Arnone commented 12 months ago

How to download the version with the bug fixed ?

PalmerAL commented 12 months ago

@M-Arnone You can either wait for the next published release, or build it yourself: https://github.com/minbrowser/min#building-binaries

iambudi commented 12 months ago

@M-Arnone You can either wait for the next published release, or build it yourself: https://github.com/minbrowser/min#building-binaries

I tried to run npm run start on node v20.8.0 and show this error popup. image

npm install readable-stream seems does not help

iambudi commented 11 months ago

Fixed in 1180df5, thanks for reporting.

@iambudi Can you add a screenshot in a new issue?

2330

PalmerAL commented 11 months ago

@iambudi I can't reproduce this; maybe try deleting your whole node_modules folder and reinstalling?