minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.9k stars 701 forks source link

My changes not included in buildWindows #2338

Closed tahaontech closed 10 months ago

tahaontech commented 11 months ago

I use your source code for a university project and I have a problem with the build.

I added a few lines of code and a few events inside 'viewManager.js' these changes work perfectly in development but when I build the app with buildWindows command these changes do not work in production.

PalmerAL commented 11 months ago

That's strange; what's the exact sequence of steps you're performing?

mohammadhasanii commented 10 months ago

That's strange; what's the exact sequence of steps you're performing?

For example, I used axios and I am making a request to a certain place, but no request is given at all. Of course, I use const. Is it because of this?

Should I use var?

PalmerAL commented 10 months ago

Are you related to the issue author?

Anyway, 1) how are you compiling and installing the app - are you sure you're running the version with your changes? 2) try opening the browser dev tools (inspect browser) and debug what's happening.

mohammadhasanii commented 10 months ago

fixed. I found the problem. Thank you for your answer

mohammadhasanii commented 10 months ago

You can done the issue This is my friend's account We are both working on a project