minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.71k stars 684 forks source link

Allowing Google sign in customFilters.txt stop github.com from loading #2385

Closed J-Siu closed 4 months ago

J-Siu commented 4 months ago

Expected Behavior

github.com load normally

Actual Behavior

Min just display a white page and can't even open inspector.

To Reproduce

  1. Add following line in customFilters.txt
    @@||https://accounts.google.com/v3/signin/_/AccountsSignInUi/browserinfo
    @@||https://www.googleapis.com/
  2. Restart Min
  3. Go to https://github.com/

The two lines are for allowing webapp that use google login.

The issue is caused by the 2nd line @@||https://www.googleapis.com/. Once that line is in, github.com no longer load.

PalmerAL commented 4 months ago

Thanks for the detail. Unfortunately I can't reproduce with those steps, on either the logged-in or logged-out homepages. Are there any other settings you have that are different from the defaults?

This has been reported by other people as well: #2377. @iambudi @flightmansam do you have any similar content blocking rules set up?

J-Siu commented 4 months ago

It look exactly the same. I will close this continue in https://github.com/minbrowser/min/issues/2377. Thank you!!