search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.89k stars 698 forks source link

enable Github Actions build with os matrix #2430

Closed alswl closed 2 months ago

alswl commented 5 months ago

This issue enables GitHub Actions to build with an OS matrix and automatically generate a release draft. Upon completion of the pipeline, a release will be drafted automatically.

The workflow operates similarly to this example. The release is similarly to this.

PalmerAL commented 5 months ago

Thanks! I think the matrix changes look good.

I'm a little bit skeptical about importing a third-party action that has permissions to directly upload releases. Is there a way to scope GITHUB_TOKEN so that it can only publish draft releases? If not, I'd probably prefer to keep uploading the artifacts manually.

alswl commented 5 months ago

Hi @PalmerAL ,

For a better understanding of GITHUB_TOKEN and its permissions in GitHub Actions, you can refer to the official documentation. It outlines how the token is used and what permissions it has by default.

The grant feature seems to be tailored for workflows, allowing you to manually adjust the permissions for specific pipelines as detailed here.

Additionally, svenstaro/upload-release-action is a popular action that operates at the repository level only. Given this scope limitation, using the token with this action should be secure.

alswl commented 4 months ago

@PalmerAL ping.

alswl commented 4 months ago

@PalmerAL Is this pull request applicable to this project. If it is feasible, I will resolve the conflict, otherwise I will close it.

PalmerAL commented 2 months ago

Sorry, I forgot about this. I don't think github_token supports a fine-grained enough scope to limit to only draft releases (assuming this is still true: https://stackoverflow.com/questions/67389957/what-permissions-does-github-token-require-for-releases-from-a-github-action). So I don't want to move forward with that part.

The reorganization of the action seems good, so up to you if you want to go forward with that.

alswl commented 2 months ago

@PalmerAL OK, I removed the drafting release action. Please review my pull-request again.

PalmerAL commented 2 months ago

Thanks!