search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.92k stars 704 forks source link

Need an option to disable all keyboard shortcuts #263

Open renkun-ken opened 7 years ago

renkun-ken commented 7 years ago

I use web-based emacs editors in this browser so that the conflicts of keyboard shortcuts between emacs and browser can be minimized. I find it very hard to do the same in IE, Firefox, and Chrome simply because they have many keyboard shortcuts and cannot be easily modified or disabled.

I'm wondering if it's possible to add an option to disable all keyboard shortcuts? I tried to leave those text-boxes blank in the preference but it turns out not to work but reset. I have to add ctrl+ to all shortcuts so that emacs key bindings are mostly respected.

PalmerAL commented 7 years ago

I'm not sure adding an option is a good idea, since it would only be used by a few people. Would changing the text boxes so they don't reset when they are left blank be a good solution?

renkun-ken commented 7 years ago

@PalmerAL This definitely works! Adding an option surely is an overkill. Just need a way to remove conflicting/unwanted shortcuts. Currently I just type something not a key to do that, e.g. ...

code-hunger commented 7 years ago

You could just put a return; statement right in the beginning of the defineShortcut function in js/keybindings.js on line 116 instead of filling all the checkboxes with random values. It might be overkill for an option but I think it still deserves its place somewhere in the interface, particularly on the CLI. When cli support is added it could be added as a command argument.