search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.98k stars 709 forks source link

Will there ever be an option for a popup blocker? #683

Open LukaFX opened 5 years ago

LukaFX commented 5 years ago

Popups on websites like "save 50%" or something like that is really annoying. Maybe a feature to blovk those?

PalmerAL commented 5 years ago

Good idea!

For actual popups (the ones that open in a new tab, created using window.open), we would need to show a notification bar with a button to open the popup (like Firefox does). However, I'm guessing what you're referring to are just dialog boxes that open on top of the page (example). For those, we'd need to implement support for cosmetic filters, which would then let us use the rules in lists like EasyList to figure out which popups to block.

It's pretty easy to implement a working version of this, but getting it to run fast is tricky. Adblock Plus injects a huge CSS stylesheet with all of the filters into every webpage, which consumes a lot of memory and causes the brower to do more work when restyling the page. uBlock Origin seems to work better (I believe that extension has it's own selector matching written in JS); it's probably worth investigating how that works in more detail.

Nesaijn commented 3 years ago

Cosmetic filters is also a thing I would love to see. I would like to use the filters provided by uBlock Origin: https://github.com/uBlockOrigin/uAssets/tree/master/filters