search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.89k stars 698 forks source link

Ad block problems #685

Open LukaFX opened 5 years ago

LukaFX commented 5 years ago

Ad block does not work on Twitch.tv. Also on YouTube and some other websites there is still a space where the ad was and is taking up a blank space. Also read my reply to the last issue I posted :) Thanks!

PalmerAL commented 5 years ago

Ad block does not work on Twitch.tv.

Does this work with any other ad blockers? It looks like Twitch mixes the ads and the actual video together, so it's hard to block just one. uBlock Origin includes a special script that is supposed to block Twitch from loading the ads: https://github.com/uBlockOrigin/uAssets/blob/40c38474f9b9c727e2b5cd73f8e040e47c1164c0/filters/resources.txt#L2329, but it doesn't seem to work fully either - I don't see ads in Firefox, but I'm still seeing ads in Chrome.

Also on YouTube and some other websites there is still a space where the ad was and is taking up a blank space.

This is probably also because of a lack of cosmetic filtering, which is what you mentioned in the other issue. I guess we could add something like uBlock's "element picker" so you could block these without adding full support for cosmetic filtering.