minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
7.84k stars 695 forks source link

Temporary whitelisting of scripts with `block scripts` enabled #892

Open csark opened 4 years ago

csark commented 4 years ago

I was recently testing out the block scripts feature. It works as intended, but it would be a nice usability addition if the user could temporarily whitelist scripts for certain sites that don't work with that feature enabled. This feature exists in an extension like 'NoScript', is this something that could be implemented here?

PalmerAL commented 4 years ago

It seems like a decent feature to add, but I wonder if we're going to eventually end up re-implementing most of noscript, which I'd rather not do. Can you explain more about how you want to use this feature?

When I've tried to disable JS in the past, my experience has been that most sites are basically unusable, so instead of trying to do that, I've figured it's better to keep expanding what reader mode can do until it's usable on most sites where JS isn't necessary. However, if there's a usecase that doesn't cover, then it may be worth considering adding more controls for this.

csark commented 4 years ago

One thing I like about this noscript is I can set it to trust JS files from top-level sites. This will allow most websites to load normally while blocking ad/tracking scripts. However, some still need a few scripts from a different domain that the website controls. For example on GitHub that is githubassets.com. In min it is just an all or nothing approach which makes the feature not that useful unless you literally only go to sites that don't use scripts.

That being said, I haven't measured the delta between what noscript blocks and what gets blocked by turning on the Block all ads and trackers feature. Maybe there is overlap there that I am looking for.