search

minbrowser / min

A fast, minimal browser that protects your privacy
https://minbrowser.org/
Apache License 2.0
8k stars 709 forks source link

Additional explanation to settings page #950

Open flber opened 4 years ago

flber commented 4 years ago

I've added a bit of extra information on the settings page to clarify how the password autofill works:

changeToSettings

I've made a separate branch called password-fill-tweaks to work on this and maybe a few other aesthetic and ease-of-use GUI things, but I can't publish the branch because I don't have permission.

PalmerAL commented 4 years ago

If it's hard to figure out how to use autofill, I sort of wonder if it would be better to make the UI easier to understand (maybe a different icon?) rather than adding an explanation for it.

Regarding the permission issues, are you making a branch directly in this repository? If that's the case, you need to make a fork of it (from the github UI), make the branch in your forked copy, and then make a PR to this repository instead.

flber commented 4 years ago

Ah, got it. And maybe? I was planning on trying to make the UI a bit easier to understand anyway, so I'd be up for adding a few other things as well. I think the icon is good, but I think it needs a bit more interactivity. The button almost doesn't seem to do anything (especially when you don't have a password saved for a site), so I was planning on adding an additional UI element to essentially tell the user what it's state is. Do you have any ideas for how to implement that, or even just where to start looking?

PalmerAL commented 4 years ago

The icon's supposed to turn red if no saved passwords are found, is that not working? Although I do agree there could probably be a more clear indication than that.

The actual button UI is in js/preload/passwordFill.js. When you click the button, it sends a password-autofill IPC message to the main window, which causes this code to run, find the matching passwords, and send them back to the page. When the tab receives the matched passwords, this code runs and updates the button state.