minchao / mitake-php

三竹簡訊 PHP SDK
MIT License
33 stars 6 forks source link

增加 http path #3

Closed y2468101216 closed 6 years ago

y2468101216 commented 6 years ago

增加 readme.md 說明跟 client 設置,未修正 cli 介面

y2468101216 commented 6 years ago

continuous-integration/appveyor/pr — AppVeyor build failed 這個該怎修?

codecov[bot] commented 6 years ago

Codecov Report

Merging #3 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #3      +/-   ##
============================================
+ Coverage     99.37%   99.39%   +0.01%     
- Complexity       99      101       +2     
============================================
  Files            10       10              
  Lines           322      330       +8     
============================================
+ Hits            320      328       +8     
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
src/Client.php 97.18% <100%> (+0.35%) 23 <2> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0849674...179a136. Read the comment docs.

minchao commented 6 years ago

AppVeyor build failed

看起來是測試環境的初始化過程出錯了,可以先忽略它。XD

The Travis CI build failed

由於設定了 Coding Style 檢查,需要修正以下錯誤:

FILE: /home/travis/build/minchao/mitake-php/src/Client.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 163 | ERROR | [ ] Expected "function abc(...)"; found "function abc
     |       |     (...)"
     |       |     (Squiz.Functions.FunctionDeclaration.Found)
 163 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1
     |       |     found
     |       |     (Squiz.Functions.MultiLineFunctionDeclaration.SpaceBeforeOpenParen)
 165 | ERROR | [x] Expected 1 space(s) after IF keyword; 0 found
     |       |     (Squiz.ControlStructures.ControlSignature.SpaceAfterKeyword)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
y2468101216 commented 6 years ago

好,我回家修一下 code style

y2468101216 commented 6 years ago

以修正

minchao commented 6 years ago

謝謝您 😀