Closed black7375 closed 3 months ago
Triggered from https://github.com/mincho-js/mincho/pull/36 by @​black7375.
Checking if we can fast forward main
(cc6e3c6cfcee19f7d654b0389ac1e0076fbcfd22) to bundler-setup
(50fdebad5bbb13bb2a2ebe48edbac848d4454164).
Target branch (main
):
commit cc6e3c6cfcee19f7d654b0389ac1e0076fbcfd22 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Jul 17 15:52:17 2024 +0900
Chore: Console debug package #33
Pull request (bundler-setup
):
commit 50fdebad5bbb13bb2a2ebe48edbac848d4454164 (pull_request/bundler-setup)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Fri Jul 19 17:07:06 2024 +0900
Clean: Config formatting #35
It is possible to fast forward main
(cc6e3c6cfcee19f7d654b0389ac1e0076fbcfd22) to bundler-setup
(50fdebad5bbb13bb2a2ebe48edbac848d4454164). If you have write access to the target repository, you can add a comment with /fast-forward
to fast forward main
to bundler-setup
.
This update introduces several new configuration files for Visual Studio Code, enhancing the development environment for JavaScript and TypeScript projects. Key additions include recommended extensions for linting and formatting, tailored editor settings, and refined ESLint and TypeScript configurations. These changes simplify setup, improve code quality, and ensure a consistent coding experience across the team.
Files | Change Summary |
---|---|
configs/eslint-config-custom/.vscode/extensions.json configs/vite-config-custom/.vscode/extensions.json |
New configuration files that recommend ESLint and Prettier extensions for improved linting and formatting in Visual Studio Code. |
configs/eslint-config-custom/.vscode/settings.json configs/vite-config-custom/.vscode/settings.json |
New settings files enhancing editor behavior, auto-saving, TypeScript SDK configurations, and ESLint integration for a better developer experience. |
configs/eslint-config-custom/eslint.config.base.js |
Reformatted the ignores array for improved readability without changing functionality. |
configs/tsconfig-custom/tsconfig.json |
Added @mincho/debug-log/importMeta to the types array for enhanced type definitions and IntelliSense support. |
configs/vite-config-custom/index.d.ts |
Narrowed TInputConfig type to the first parameter of the defineConfig function for better type safety. |
configs/vite-config-custom/index.js |
Enhanced build configuration with TypeScript checks, added output paths for declaration files, and refined plugin handling to better support both ES and CommonJS formats. |
configs/vite-config-custom/package.json |
Updated devDependencies to include a custom Prettier configuration and a new plugin for externalizing dependencies. |
packages/debug-log/importMeta.d.ts |
Introduced a new interface ImportMeta extending TypeScript capabilities for debugging functionalities. |
packages/debug-log/package.json |
Updated module paths and added importMeta.d.ts for better structure and clarity in exports. |
packages/transform-to-vanilla/package.json |
Adjusted paths for typings and exports for consistency across module formats. |
turbo.json |
Modified lint and test sections to enhance task dependencies, ensuring linting occurs after building. |
sequenceDiagram
participant Developer
participant VSCode
participant ESLint
participant Prettier
participant BuildSystem
Developer->>VSCode: Open project
VSCode->>ESLint: Check code quality
VSCode->>Prettier: Format code
Developer->>BuildSystem: Run build
BuildSystem->>ESLint: Run linting
BuildSystem->>Prettier: Run formatting
Developer->>BuildSystem: Test changes
🐰 In a world where codes entwine,
A rabbit hops with joy divine.
With settings and paths all in line,
Our code will flourish, oh so fine!
Extensions sprout like flowers in spring,
Together we'll code, let the laughter ring! 🌸
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
/fast-forward
Triggered from https://github.com/mincho-js/mincho/pull/36#issuecomment-2238685948 by @​black7375.
Trying to fast forward main
(cc6e3c6cfcee19f7d654b0389ac1e0076fbcfd22) to bundler-setup
(50fdebad5bbb13bb2a2ebe48edbac848d4454164).
Target branch (main
):
commit cc6e3c6cfcee19f7d654b0389ac1e0076fbcfd22 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Jul 17 15:52:17 2024 +0900
Chore: Console debug package #33
Pull request (bundler-setup
):
commit 50fdebad5bbb13bb2a2ebe48edbac848d4454164 (pull_request/bundler-setup)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Fri Jul 19 17:07:06 2024 +0900
Clean: Config formatting #35
Fast forwarding main
(cc6e3c6cfcee19f7d654b0389ac1e0076fbcfd22) to bundler-setup
(50fdebad5bbb13bb2a2ebe48edbac848d4454164).
$ git push origin 50fdebad5bbb13bb2a2ebe48edbac848d4454164:main
To https://github.com/mincho-js/mincho.git
cc6e3c6..50fdeba 50fdebad5bbb13bb2a2ebe48edbac848d4454164 -> main
Description
Implement #35 Resolve various dependency and bundling issues.
I also pluginised to make it easier to use
debugLog
during testing.Summary by CodeRabbit
New Features
@mincho/debug-log
module.Bug Fixes
import.meta
in CommonJS contexts.Chores
package.json
files across multiple packages to streamline development practices.