mincho-js / mincho

Natural CSS in TypeScript
MIT License
40 stars 0 forks source link

Feat: Transform - Property reference #46 #47

Closed black7375 closed 3 months ago

black7375 commented 3 months ago

Description

Implement property reference

Related Issue

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@black7375 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 42 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 5762ea8adce34c71d1d1e4ea953eec4c8fd10f8a and 8da12f00a8885eab4b4b9ce25957bef0c55bd7ac.

Walkthrough

The recent changes significantly enhance CSS style transformations by implementing a structured propertyReference in the TransformContext. This update facilitates dynamic handling of nested properties and more effective resolution of references. Key improvements include context cloning, updates to property references, and comprehensive testing to validate these transformations. Overall, these enhancements provide a more flexible and robust mechanism for managing CSS properties and their interactions.

Changes

Files Change Summary
.../transform-object/index.ts, .../transform-object/rule-context.ts Updated TransformContext to include propertyReference. Modified style processing to utilize this structure.
.../transform-values/property-reference.ts Introduced functionality to replace property references in strings, supporting recursive resolution and type safety checks.
.../transform-values/simply-important.ts Added a test case to verify simplyImportant behavior for strings already containing !important.

Poem

In the garden of styles where rabbits play,
New references bloom, brightening the day.
With context so rich, and values to share,
We hop through the code, transforming with flair.
Let's dance with our styles, let creativity flow,
Each property linked, watch our garden grow! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/47 by @​black7375.

Checking if we can fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (791954885ffa7af1e368fd3d194001bfb106839f).

Target branch (main):

commit 4975f3afe25ea520e053c25016e5384e2bac63cf (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Jul 21 15:46:21 2024 +0900

    Fix: DebugLog - declare type with function overload #40

Pull request (property-reference):

commit 791954885ffa7af1e368fd3d194001bfb106839f (pull_request/property-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Jul 22 20:52:35 2024 +0900

    Feat: Transform - Property reference #46

It is possible to fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (791954885ffa7af1e368fd3d194001bfb106839f). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to property-reference.

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/47 by @​black7375.

Checking if we can fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (0fb7541c8eaf5ac2a3d598ddbada12b61bc33763).

Target branch (main):

commit 4975f3afe25ea520e053c25016e5384e2bac63cf (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Jul 21 15:46:21 2024 +0900

    Fix: DebugLog - declare type with function overload #40

Pull request (property-reference):

commit 0fb7541c8eaf5ac2a3d598ddbada12b61bc33763 (pull_request/property-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Jul 22 21:08:15 2024 +0900

    Feat: Transform - Property reference #46

It is possible to fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (0fb7541c8eaf5ac2a3d598ddbada12b61bc33763). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to property-reference.

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/47 by @​black7375.

Checking if we can fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (fb90c52da28ed850eac02b5ae5265c5a3970fc89).

Target branch (main):

commit 4975f3afe25ea520e053c25016e5384e2bac63cf (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Jul 21 15:46:21 2024 +0900

    Fix: DebugLog - declare type with function overload #40

Pull request (property-reference):

commit fb90c52da28ed850eac02b5ae5265c5a3970fc89 (pull_request/property-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Wed Jul 24 20:13:24 2024 +0900

    Fix: Transform - Literal property refence cases #46

It is possible to fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (fb90c52da28ed850eac02b5ae5265c5a3970fc89). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to property-reference.

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/47 by @​black7375.

Checking if we can fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (5762ea8adce34c71d1d1e4ea953eec4c8fd10f8a).

Target branch (main):

commit 4975f3afe25ea520e053c25016e5384e2bac63cf (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Jul 21 15:46:21 2024 +0900

    Fix: DebugLog - declare type with function overload #40

Pull request (property-reference):

commit 5762ea8adce34c71d1d1e4ea953eec4c8fd10f8a (pull_request/property-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Wed Jul 24 20:19:14 2024 +0900

    Fix: Transform - Literal property refence cases #46

It is possible to fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (5762ea8adce34c71d1d1e4ea953eec4c8fd10f8a). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to property-reference.

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/47 by @​black7375.

Checking if we can fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (8da12f00a8885eab4b4b9ce25957bef0c55bd7ac).

Target branch (main):

commit 4975f3afe25ea520e053c25016e5384e2bac63cf (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Jul 21 15:46:21 2024 +0900

    Fix: DebugLog - declare type with function overload #40

Pull request (property-reference):

commit 8da12f00a8885eab4b4b9ce25957bef0c55bd7ac (pull_request/property-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Wed Jul 24 20:23:32 2024 +0900

    Fix: Transform - Literal property refence cases #46

It is possible to fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (8da12f00a8885eab4b4b9ce25957bef0c55bd7ac). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to property-reference.

black7375 commented 3 months ago

/fast-forward

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/47#issuecomment-2247667920 by @​black7375.

Trying to fast forward main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (8da12f00a8885eab4b4b9ce25957bef0c55bd7ac).

Target branch (main):

commit 4975f3afe25ea520e053c25016e5384e2bac63cf (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Jul 21 15:46:21 2024 +0900

    Fix: DebugLog - declare type with function overload #40

Pull request (property-reference):

commit 8da12f00a8885eab4b4b9ce25957bef0c55bd7ac (pull_request/property-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Wed Jul 24 20:23:32 2024 +0900

    Fix: Transform - Literal property refence cases #46

Fast forwarding main (4975f3afe25ea520e053c25016e5384e2bac63cf) to property-reference (8da12f00a8885eab4b4b9ce25957bef0c55bd7ac).

$ git push origin 8da12f00a8885eab4b4b9ce25957bef0c55bd7ac:main
To https://github.com/mincho-js/mincho.git
   4975f3a..8da12f0  8da12f00a8885eab4b4b9ce25957bef0c55bd7ac -> main