search

mincho-js / mincho

Natural CSS in TypeScript
MIT License
40 stars 0 forks source link

Implement Variant Reference #50 #57

Closed black7375 closed 3 months ago

black7375 commented 3 months ago

Description

Implement Variant Reference

Related Issue

Summary by CodeRabbit

Additional context

Checklist

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/57 by @​black7375.

Checking if we can fast forward main (c06046b8b00308c4d855c831a68a3178770b32e4) to variants-reference (65aee375becde2ad1a42701a0923bd9214f8ab37).

Target branch (main):

commit c06046b8b00308c4d855c831a68a3178770b32e4 (HEAD -> main, origin/main, origin/HEAD)
Author: JeongJun <rgfdds98@gmail.com>
Date:   Sun Jul 28 17:43:34 2024 +0900

    Fix: rewrite gitignore and yarnrc.yml #51

Pull request (variants-reference):

commit 65aee375becde2ad1a42701a0923bd9214f8ab37 (pull_request/variants-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 3 16:46:15 2024 +0900

    Refactor: Remove duplicate code and declarations #50

It is possible to fast forward main (c06046b8b00308c4d855c831a68a3178770b32e4) to variants-reference (65aee375becde2ad1a42701a0923bd9214f8ab37). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to variants-reference.

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes enhance the functionality of the CSS handling and transformation modules. Key improvements include a more flexible cssVariants function, enriched transformation context capabilities, and refined management of variant references. These updates streamline the styling and transformation processes, offering a broader API and improved internal logic for handling complex styles.

Changes

Files Change Summary
packages/css/src/index.ts Enhanced cssVariants function with broader input support and introduced styleVariants alias.
packages/transform-to-vanilla/src/transform-object/rule-context.ts Modified createPathSetter for variant reference management and removed deepmerge dependency.
packages/transform-to-vanilla/src/transform-object/index.ts Updated TransformContext with new properties and added mergeVariantReference function.
packages/transform-to-vanilla/src/transform-to-vanilla/src/transform.ts Updated transform function to accept a complex context and handle variant references.
packages/transform-to-vanilla/src/utils/object.ts New file with mergeObject and isEmptyObject functions for object handling.
packages/transform-to-vanilla/src/transform-object/variant-reference.ts Introduced replaceVariantReference function for handling variant references.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CSS_Module as CSS Variants Module
    participant Transform_Module as Transform Module

    User->>CSS_Module: Call cssVariants(styleMapOrData)
    CSS_Module->>CSS_Module: Process input based on type
    CSS_Module->>CSS_Module: Call processVariants for transformation
    CSS_Module-->>User: Return processed styles

    User->>Transform_Module: Call transform(style, context)
    Transform_Module->>Transform_Module: Merge variant references
    Transform_Module-->>User: Return transformed style

🐇 Hop along the code, a leap so spry,
New features sprout, reaching the sky!
With variants and styles all in a dance,
Transformation magic, give it a chance!
In the world of CSS, we twirl and play,
Celebrate changes, hip-hip hooray! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/57 by @​black7375.

Checking if we can fast forward main (c06046b8b00308c4d855c831a68a3178770b32e4) to variants-reference (c97fb7bc2a4af85bfd8ea83713375158661c1d71).

Target branch (main):

commit c06046b8b00308c4d855c831a68a3178770b32e4 (HEAD -> main, origin/main, origin/HEAD)
Author: JeongJun <rgfdds98@gmail.com>
Date:   Sun Jul 28 17:43:34 2024 +0900

    Fix: rewrite gitignore and yarnrc.yml #51

Pull request (variants-reference):

commit c97fb7bc2a4af85bfd8ea83713375158661c1d71 (pull_request/variants-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Aug 4 17:17:21 2024 +0900

    Fix: Prototype-polluting assignment and Simplify Type Assertions #50

It is possible to fast forward main (c06046b8b00308c4d855c831a68a3178770b32e4) to variants-reference (c97fb7bc2a4af85bfd8ea83713375158661c1d71). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to variants-reference.

black7375 commented 3 months ago

/fast-forward

github-actions[bot] commented 3 months ago

Triggered from https://github.com/mincho-js/mincho/pull/57#issuecomment-2280289632 by @​black7375.

Trying to fast forward main (c06046b8b00308c4d855c831a68a3178770b32e4) to variants-reference (c97fb7bc2a4af85bfd8ea83713375158661c1d71).

Target branch (main):

commit c06046b8b00308c4d855c831a68a3178770b32e4 (HEAD -> main, origin/main, origin/HEAD)
Author: JeongJun <rgfdds98@gmail.com>
Date:   Sun Jul 28 17:43:34 2024 +0900

    Fix: rewrite gitignore and yarnrc.yml #51

Pull request (variants-reference):

commit c97fb7bc2a4af85bfd8ea83713375158661c1d71 (pull_request/variants-reference)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sun Aug 4 17:17:21 2024 +0900

    Fix: Prototype-polluting assignment and Simplify Type Assertions #50

Fast forwarding main (c06046b8b00308c4d855c831a68a3178770b32e4) to variants-reference (c97fb7bc2a4af85bfd8ea83713375158661c1d71).

$ git push origin c97fb7bc2a4af85bfd8ea83713375158661c1d71:main
To https://github.com/mincho-js/mincho.git
   c06046b..c97fb7b  c97fb7bc2a4af85bfd8ea83713375158661c1d71 -> main