search

mincho-js / mincho

Natural CSS in TypeScript
MIT License
35 stars 0 forks source link

Fix: Prevent paths from triggering #81 & publish test #82

Closed black7375 closed 1 month ago

black7375 commented 1 month ago

Description

Preventing invalid triggers

Related Issue

Summary by CodeRabbit

Additional context

Checklist

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 86ac9cac9873361ae2061637351d4d2611516352

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 month ago

Walkthrough

This update includes enhancements to a GitHub Actions workflow, specifically tightening the conditional logic for detecting the /fast-forward command to prevent false triggers. Additionally, the @mincho-js/debug-log package has been updated from version 1.0.3 to 1.0.4, with a changelog note indicating the reinstatement of a test. These changes improve the reliability of workflow triggers and document the state of the package.

Changes

File Change Summary
.github/workflows/fast-forward.yml Improved command detection logic in GitHub Actions to ensure /fast-forward is recognized as a standalone word.
packages/debug-log/CHANGELOG.md Added version entry 1.0.4 noting the re-publication of a test in the changelog for @mincho-js/debug-log.
packages/debug-log/package.json Updated version from 1.0.3 to 1.0.4 in package.json for @mincho-js/debug-log, indicating a new release.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHubActions
    participant DebugLog

    User->>GitHubActions: Comment with "/fast-forward"
    GitHubActions->>GitHubActions: Check for command
    alt Command is standalone
        GitHubActions->>DebugLog: Trigger fast forward job
    else Command is part of text
        GitHubActions-->>User: Ignore command
    end

🐰 In the meadow, changes sprout,
A command refined, no doubt!
Debug logs now shine bright,
With tests restored, all feels right.
Hops of joy, let’s celebrate,
With every fix, we elevate! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/82 by @​black7375.

Checking if we can fast forward main (361e0778f485330e469f48121e8efa2a4bc83e82) to publish-test (86ac9cac9873361ae2061637351d4d2611516352).

Target branch (main):

commit 361e0778f485330e469f48121e8efa2a4bc83e82 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 21:44:46 2024 +0900

    Chore: Revert #79 and Show logs on failure

Pull request (publish-test):

commit 86ac9cac9873361ae2061637351d4d2611516352 (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:15:44 2024 +0900

    Fix: Prevent paths from triggering #81 & publish test

It is possible to fast forward main (361e0778f485330e469f48121e8efa2a4bc83e82) to publish-test (86ac9cac9873361ae2061637351d4d2611516352). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to publish-test.

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/82#issuecomment-2294857204 by @​coderabbitai[bot].

Trying to fast forward main (361e0778f485330e469f48121e8efa2a4bc83e82) to publish-test (86ac9cac9873361ae2061637351d4d2611516352).

Target branch (main):

commit 361e0778f485330e469f48121e8efa2a4bc83e82 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 21:44:46 2024 +0900

    Chore: Revert #79 and Show logs on failure

Pull request (publish-test):

commit 86ac9cac9873361ae2061637351d4d2611516352 (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:15:44 2024 +0900

    Fix: Prevent paths from triggering #81 & publish test

curl: (3) bad range in URL position 74: https://api.github.com/repos/mincho-js/mincho/collaborators/coderabbitai[bot]/permission ^

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/82#issuecomment-2294857204 by @​coderabbitai[bot].

Trying to fast forward main (361e0778f485330e469f48121e8efa2a4bc83e82) to publish-test (86ac9cac9873361ae2061637351d4d2611516352).

Target branch (main):

commit 361e0778f485330e469f48121e8efa2a4bc83e82 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 21:44:46 2024 +0900

    Chore: Revert #79 and Show logs on failure

Pull request (publish-test):

commit 86ac9cac9873361ae2061637351d4d2611516352 (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:15:44 2024 +0900

    Fix: Prevent paths from triggering #81 & publish test

curl: (3) bad range in URL position 74: https://api.github.com/repos/mincho-js/mincho/collaborators/coderabbitai[bot]/permission ^

black7375 commented 1 month ago

/fast-forward

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/82#issuecomment-2294857752 by @​black7375.

Trying to fast forward main (361e0778f485330e469f48121e8efa2a4bc83e82) to publish-test (86ac9cac9873361ae2061637351d4d2611516352).

Target branch (main):

commit 361e0778f485330e469f48121e8efa2a4bc83e82 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 21:44:46 2024 +0900

    Chore: Revert #79 and Show logs on failure

Pull request (publish-test):

commit 86ac9cac9873361ae2061637351d4d2611516352 (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:15:44 2024 +0900

    Fix: Prevent paths from triggering #81 & publish test

Fast forwarding main (361e0778f485330e469f48121e8efa2a4bc83e82) to publish-test (86ac9cac9873361ae2061637351d4d2611516352).

$ git push origin 86ac9cac9873361ae2061637351d4d2611516352:main
To https://github.com/mincho-js/mincho.git
   361e077..86ac9ca  86ac9cac9873361ae2061637351d4d2611516352 -> main