search

mincho-js / mincho

Natural CSS in TypeScript
MIT License
35 stars 0 forks source link

Fix: Prevents the scripts' `publish` from being executed #77 #83

Closed black7375 closed 1 month ago

black7375 commented 1 month ago

Description

Ensure that it publishes without errors.

Related Issue

Summary by CodeRabbit

Additional context

Checklist

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 7dadd5a7436d0fda5e86c0d8370431e49a25300a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/83 by @​black7375.

Checking if we can fast forward main (86ac9cac9873361ae2061637351d4d2611516352) to publish-test (1dadf89d1dfe6c775bb18516333873f26b7be6d3).

Target branch (main):

commit 86ac9cac9873361ae2061637351d4d2611516352 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:15:44 2024 +0900

    Fix: Prevent paths from triggering #81 & publish test

Pull request (publish-test):

commit 1dadf89d1dfe6c775bb18516333873f26b7be6d3 (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:37:33 2024 +0900

    Fix: Prevents the scripts' `publish` from being executed #77

It is possible to fast forward main (86ac9cac9873361ae2061637351d4d2611516352) to publish-test (1dadf89d1dfe6c775bb18516333873f26b7be6d3). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to publish-test.

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent changes streamline the project's build and deployment processes by removing the publish script from several package configurations, signaling a shift towards alternative distribution methods. Additionally, the version script has been renamed to changeset:version in the main package.json, enhancing clarity in version management. Overall, these adjustments foster a more organized and efficient workflow.

Changes

Files Change Summary
package.json, packages/css-additional-types/package.json, packages/css/package.json, packages/debug-log/package.json, packages/transform-to-vanilla/package.json Removed the publish script from multiple packages to streamline the build process. Renamed the version script to changeset:version in the main package.json.
packages/debug-log/CHANGELOG.md Added a CHANGELOG entry for version 1.0.5, noting that a test is being published again.

Poem

🐰 In the garden where scripts used to play,
The publish hops off, finding a new way.
With changeset guiding our versioning bright,
Our workflow now dances, oh what a delight!
Streams of clarity flow, as rabbits we cheer,
Embracing the changes, our path is now clear! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
black7375 commented 1 month ago

/fast-forward

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/83 by @​black7375.

Checking if we can fast forward main (2ab40248b66d7d37ef5d8bfd9d79620e00f31d6b) to publish-test (0d18b5d0c512a8478153f48457d7b26ecc350b4a).

Target branch (main):

commit 2ab40248b66d7d37ef5d8bfd9d79620e00f31d6b (HEAD -> main, origin/main, origin/HEAD)
Author: MS_Y <alstjr7375@daum.net>
Date:   Sat Aug 17 22:49:26 2024 +0900

    Fix: `match` not working #81

Pull request (publish-test):

commit 0d18b5d0c512a8478153f48457d7b26ecc350b4a (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:37:33 2024 +0900

    Fix: Prevents the scripts' `publish` from being executed #77

It is possible to fast forward main (2ab40248b66d7d37ef5d8bfd9d79620e00f31d6b) to publish-test (0d18b5d0c512a8478153f48457d7b26ecc350b4a). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to publish-test.

black7375 commented 1 month ago

@coderabbitai review

coderabbitai[bot] commented 1 month ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
black7375 commented 1 month ago

/fast-forward

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/83 by @​black7375.

Checking if we can fast forward main (9214ac4cbeff9e3b0908befe8e929ff9ec64d63f) to publish-test (f667c550ebc5be23dd8aa1718420c781139b8f6d).

Target branch (main):

commit 9214ac4cbeff9e3b0908befe8e929ff9ec64d63f (HEAD -> main, origin/main, origin/HEAD)
Author: MS_Y <alstjr7375@daum.net>
Date:   Sat Aug 17 23:00:23 2024 +0900

    Fix: `match` not working #81

Pull request (publish-test):

commit f667c550ebc5be23dd8aa1718420c781139b8f6d (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:37:33 2024 +0900

    Fix: Prevents the scripts' `publish` from being executed #77

It is possible to fast forward main (9214ac4cbeff9e3b0908befe8e929ff9ec64d63f) to publish-test (f667c550ebc5be23dd8aa1718420c781139b8f6d). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to publish-test.

black7375 commented 1 month ago

/fast-forward

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/83 by @​black7375.

Checking if we can fast forward main (e46a8f8eb7a93642b144ad732dcfbce8d55e67d3) to publish-test (7dadd5a7436d0fda5e86c0d8370431e49a25300a).

Target branch (main):

commit e46a8f8eb7a93642b144ad732dcfbce8d55e67d3 (HEAD -> main, origin/main, origin/HEAD)
Author: MS_Y <alstjr7375@daum.net>
Date:   Sat Aug 17 23:52:16 2024 +0900

    Fix: `match` not working #81

Pull request (publish-test):

commit 7dadd5a7436d0fda5e86c0d8370431e49a25300a (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:37:33 2024 +0900

    Fix: Prevents the scripts' `publish` from being executed #77

It is possible to fast forward main (e46a8f8eb7a93642b144ad732dcfbce8d55e67d3) to publish-test (7dadd5a7436d0fda5e86c0d8370431e49a25300a). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to publish-test.

black7375 commented 1 month ago

/fast-forward

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/83#issuecomment-2294882412 by @​black7375.

Trying to fast forward main (e46a8f8eb7a93642b144ad732dcfbce8d55e67d3) to publish-test (7dadd5a7436d0fda5e86c0d8370431e49a25300a).

Target branch (main):

commit e46a8f8eb7a93642b144ad732dcfbce8d55e67d3 (HEAD -> main, origin/main, origin/HEAD)
Author: MS_Y <alstjr7375@daum.net>
Date:   Sat Aug 17 23:52:16 2024 +0900

    Fix: `match` not working #81

Pull request (publish-test):

commit 7dadd5a7436d0fda5e86c0d8370431e49a25300a (pull_request/publish-test)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Aug 17 22:37:33 2024 +0900

    Fix: Prevents the scripts' `publish` from being executed #77

Fast forwarding main (e46a8f8eb7a93642b144ad732dcfbce8d55e67d3) to publish-test (7dadd5a7436d0fda5e86c0d8370431e49a25300a).

$ git push origin 7dadd5a7436d0fda5e86c0d8370431e49a25300a:main
To https://github.com/mincho-js/mincho.git
   e46a8f8..7dadd5a  7dadd5a7436d0fda5e86c0d8370431e49a25300a -> main