search

mincho-js / mincho

Natural CSS in TypeScript
MIT License
40 stars 0 forks source link

Test: core types about Rules corresponding to Recipe (1) #99

Closed Jeong-jj closed 1 month ago

Jeong-jj commented 1 month ago

Description

The core types test about Rules corresponding to Recipe.

Related Issue

Summary by CodeRabbit

Additional context

It remain about RecipeClassNames, RuntimeFn Type Test (24.09.18). I'm still thinking about type tests about these. I'll finish soon.

Checklist

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 6d5845a13ca55935449ceccc4cf3bd7d4ee931f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve the addition of new script commands in the package.json file for executing tests and watching for changes. Additionally, a series of type tests for VariantSelection, CompoundVariant, and PatternOptions are introduced in TypeScript, enhancing type safety and validation for variant-related structures using Vitest.

Changes

Files Change Summary
packages/css/package.json Added new script commands: "test": "yarn g:test" and "test:watch": "yarn g:test-watch".
packages/css/src/rules/types.ts Added type tests for VariantSelection<ExampleVariants>, CompoundVariant<Variants>, and PatternOptions<Variants>.

Possibly related PRs

Poem

In the land of types, so bright and clear,
Variants dance, with no hint of fear.
Tests now abound, both strong and true,
Ensuring our code will always renew.
With each little check, our types take flight,
A rabbit's delight, in the coding night! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/99 by @​Jeong-jj.

Checking if we can fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (61fbf5d716d1762f2940963896b4eb4f4aa7b7d8).

Target branch (main):

commit c5b0d10038d86c496581e2ca80b3e32cbaed0762 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Fri Sep 6 20:50:13 2024 +0900

    Docs: Introduce link update #90

Pull request (test/rules):

commit 61fbf5d716d1762f2940963896b4eb4f4aa7b7d8 (pull_request/test/rules)
Author: JeongJun <rgfdds98@gmail.com>
Date:   Sun Sep 8 23:42:07 2024 +0900

    Test: origin PatternOptions type test

Can't fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (61fbf5d716d1762f2940963896b4eb4f4aa7b7d8). main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) is not a direct ancestor of test/rules (61fbf5d716d1762f2940963896b4eb4f4aa7b7d8). Branches appear to have diverged at ef27468caa714eea254f9b9c6563ba2a5483a135:

* 61fbf5d716d1762f2940963896b4eb4f4aa7b7d8 Test: origin PatternOptions type test
| * c5b0d10038d86c496581e2ca80b3e32cbaed0762 Docs: Introduce link update #90
|/  
* ef27468caa714eea254f9b9c6563ba2a5483a135 Feat: Rules - Basic porting for CSS rules with vanilla extract recipe #94

commit ef27468caa714eea254f9b9c6563ba2a5483a135
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Sep 2 15:54:16 2024 +0900

    Feat: Rules - Basic porting for CSS rules with vanilla extract recipe #94

Rebase locally, and then force push to test/rules.

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/99 by @​Jeong-jj.

Checking if we can fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (b8cf197458a0f81ca8a4813b4a740a71a65d46a4).

Target branch (main):

commit c5b0d10038d86c496581e2ca80b3e32cbaed0762 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Fri Sep 6 20:50:13 2024 +0900

    Docs: Introduce link update #90

Pull request (test/rules):

commit b8cf197458a0f81ca8a4813b4a740a71a65d46a4 (pull_request/test/rules)
Author: JeongJun Jo <rgfdds98@gmail.com>
Date:   Wed Sep 18 21:04:36 2024 +0900

    Test: origin CompoundVariant Type Test

Can't fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (b8cf197458a0f81ca8a4813b4a740a71a65d46a4). main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) is not a direct ancestor of test/rules (b8cf197458a0f81ca8a4813b4a740a71a65d46a4). Branches appear to have diverged at ef27468caa714eea254f9b9c6563ba2a5483a135:

* b8cf197458a0f81ca8a4813b4a740a71a65d46a4 Test: origin CompoundVariant Type Test
* 95f9ad32707f0d3c6669e497a2d5e683e79e7806 Test: VariantSelection Type Test
* fff002291efa054af78f851eede369cb58751aca Test: origin PatternOptions type test
| * c5b0d10038d86c496581e2ca80b3e32cbaed0762 Docs: Introduce link update #90
|/  
* ef27468caa714eea254f9b9c6563ba2a5483a135 Feat: Rules - Basic porting for CSS rules with vanilla extract recipe #94

commit ef27468caa714eea254f9b9c6563ba2a5483a135
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Sep 2 15:54:16 2024 +0900

    Feat: Rules - Basic porting for CSS rules with vanilla extract recipe #94

Rebase locally, and then force push to test/rules.

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/99 by @​Jeong-jj.

Checking if we can fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (3e0f0be2e703a92b55e2dcefdc08f645c1e1b582).

Target branch (main):

commit c5b0d10038d86c496581e2ca80b3e32cbaed0762 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Fri Sep 6 20:50:13 2024 +0900

    Docs: Introduce link update #90

Pull request (test/rules):

commit 3e0f0be2e703a92b55e2dcefdc08f645c1e1b582 (pull_request/test/rules)
Author: JeongJun Jo <rgfdds98@gmail.com>
Date:   Wed Sep 18 21:04:36 2024 +0900

    Test: origin CompoundVariant Type Test

It is possible to fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (3e0f0be2e703a92b55e2dcefdc08f645c1e1b582). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to test/rules.

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/99 by @​Jeong-jj.

Checking if we can fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (32d306a2732cc273f181c0bc1a8f0536aa33ad44).

Target branch (main):

commit c5b0d10038d86c496581e2ca80b3e32cbaed0762 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Fri Sep 6 20:50:13 2024 +0900

    Docs: Introduce link update #90

Pull request (test/rules):

commit 32d306a2732cc273f181c0bc1a8f0536aa33ad44 (pull_request/test/rules)
Author: JeongJun Jo <rgfdds98@gmail.com>
Date:   Wed Sep 18 23:25:38 2024 +0900

    Fix: adding a description of the intended type error

It is possible to fast forward main (c5b0d10038d86c496581e2ca80b3e32cbaed0762) to test/rules (32d306a2732cc273f181c0bc1a8f0536aa33ad44). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to test/rules.

black7375 commented 1 month ago

@coderabbitai review

coderabbitai[bot] commented 1 month ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/99 by @​black7375.

Checking if we can fast forward main (8e58ddb31fce27bc55fbfa18542df6a33daa1349) to test/rules (6d5845a13ca55935449ceccc4cf3bd7d4ee931f8).

Target branch (main):

commit 8e58ddb31fce27bc55fbfa18542df6a33daa1349 (HEAD -> main, origin/main, origin/HEAD)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Sep 28 13:17:12 2024 +0000

    Chore(deps): Bump micromatch in the npm_and_yarn group

    Bumps the npm_and_yarn group with 1 update: [micromatch](https://github.com/micromatch/micromatch).

    Updates `micromatch` from 4.0.7 to 4.0.8
    - [Release notes](https://github.com/micromatch/micromatch/releases)
    - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/micromatch/micromatch/compare/4.0.7...4.0.8)

    ---
    updated-dependencies:
    - dependency-name: micromatch
      dependency-type: indirect
      dependency-group: npm_and_yarn
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

Pull request (test/rules):

commit 6d5845a13ca55935449ceccc4cf3bd7d4ee931f8 (pull_request/test/rules)
Author: JeongJun <rgfdds98@gmail.com>
Date:   Sun Sep 29 00:16:49 2024 +0900

    Test: origin PatternOptions type test

It is possible to fast forward main (8e58ddb31fce27bc55fbfa18542df6a33daa1349) to test/rules (6d5845a13ca55935449ceccc4cf3bd7d4ee931f8). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to test/rules.

black7375 commented 1 month ago

/fast-forward

github-actions[bot] commented 1 month ago

Triggered from https://github.com/mincho-js/mincho/pull/99#issuecomment-2380705980 by @​black7375.

Trying to fast forward main (8e58ddb31fce27bc55fbfa18542df6a33daa1349) to test/rules (6d5845a13ca55935449ceccc4cf3bd7d4ee931f8).

Target branch (main):

commit 8e58ddb31fce27bc55fbfa18542df6a33daa1349 (HEAD -> main, origin/main, origin/HEAD)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Sep 28 13:17:12 2024 +0000

    Chore(deps): Bump micromatch in the npm_and_yarn group

    Bumps the npm_and_yarn group with 1 update: [micromatch](https://github.com/micromatch/micromatch).

    Updates `micromatch` from 4.0.7 to 4.0.8
    - [Release notes](https://github.com/micromatch/micromatch/releases)
    - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/micromatch/micromatch/compare/4.0.7...4.0.8)

    ---
    updated-dependencies:
    - dependency-name: micromatch
      dependency-type: indirect
      dependency-group: npm_and_yarn
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

Pull request (test/rules):

commit 6d5845a13ca55935449ceccc4cf3bd7d4ee931f8 (pull_request/test/rules)
Author: JeongJun <rgfdds98@gmail.com>
Date:   Sun Sep 29 00:16:49 2024 +0900

    Test: origin PatternOptions type test

Fast forwarding main (8e58ddb31fce27bc55fbfa18542df6a33daa1349) to test/rules (6d5845a13ca55935449ceccc4cf3bd7d4ee931f8).

$ git push origin 6d5845a13ca55935449ceccc4cf3bd7d4ee931f8:main
To https://github.com/mincho-js/mincho.git
   8e58ddb..6d5845a  6d5845a13ca55935449ceccc4cf3bd7d4ee931f8 -> main