mincong-h / finance-toolkit

Finance Toolkit
3 stars 1 forks source link

Refactor the file detection for Revolut #86

Closed mincong-h closed 2 years ago

mincong-h commented 2 years ago

This PR fixes https://github.com/mincong-h/finance-toolkit/issues/85 . More precisely,

codecov-commenter commented 2 years ago

Codecov Report

Merging #86 (b71fd60) into master (ebd4dbf) will increase coverage by 0.71%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   94.27%   94.98%   +0.71%     
==========================================
  Files          11       11              
  Lines         611      618       +7     
  Branches       98      100       +2     
==========================================
+ Hits          576      587      +11     
+ Misses         20       18       -2     
+ Partials       15       13       -2     
Impacted Files Coverage Δ
finance_toolkit/pipeline_factory.py 100.00% <100.00%> (+12.50%) :arrow_up:
finance_toolkit/revolut.py 86.53% <100.00%> (+0.82%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more