codecov-commenter
commented
8 months ago Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.
Comparison is base (
3bdbb11) 95.03% compared to head (d0157dc) 95.20%.
| Files | Patch % | Lines |
|---|---|---|
| finance_toolkit/tx.py | 75.00% | 1 Missing and 1 partial :warning: |
| finance_toolkit/models.py | 92.30% | 1 Missing :warning: |
| finance_toolkit/pipeline.py | 96.66% | 0 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #99 +/- ## ========================================== + Coverage 95.03% 95.20% +0.17% ========================================== Files 11 12 +1 Lines 624 709 +85 Branches 103 108 +5 ========================================== + Hits 593 675 +82 - Misses 18 20 +2 - Partials 13 14 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR introduces the new concept of exchange rates in the Finance Toolkit. In the past, we added the notion of currency at account level (see issue https://github.com/mincong-h/finance-toolkit/issues/56), meaning that each account has its concurrency, e.g. EUR, USD, and the system attaches the unit to the related files. This PR makes one step forward to convert a concurrency to another currency, which facilitates the data aggregation of multiple accounts. The currencies to pick up are configured in the configuration file (finance-tools.yaml) under the section "exchange-rate".