Open lionelkusch opened 1 day ago
I agree that we should have as standard naming a possible. Sometimes the name have a historical reason (it is the way the methods were branded initially). That's why it's useful to discuss all name change we propose to do in an issues, e.g. that one.
In general, unsued code should be removed.
There is a nonhomogenous way to name files and the methods.
We need to decide if we used a unique acronym for the names of files or/and functions or the full name.
For example, the file adaptive_permutation_threshold.py contains the function ada_svr, and the file loco.py contains loco.
Moreover, the test for knockoffs.py is the only one that has the name of the function test_model_x_knockoff.