search

mind-inria / hidimstat

HiDimStat: High-dimensional statistical inference tool for Python
https://mind-inria.github.io/hidimstat
BSD 2-Clause "Simplified" License
4 stars 4 forks source link

[WIP]: e-values KO examples and utils test #8

Closed achamma723 closed 3 months ago

achamma723 commented 4 months ago

This PR restores the PR related to KO examples and unit tests.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 98.23009% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (f40b941) to head (fdd0d8d). Report is 1 commits behind head on main.

Files Patch % Lines
hidimstat/knockoff_aggregation.py 96.55% 1 Missing :warning:
hidimstat/utils.py 94.73% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ========================================== + Coverage 91.00% 91.77% +0.76% ========================================== Files 41 42 +1 Lines 2669 2760 +91 ========================================== + Hits 2429 2533 +104 + Misses 240 227 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

achamma723 commented 4 months ago

@bthirion, I think this PR from the old repo is ready to merge (What Alexandre was working on). What do you think?

achamma723 commented 4 months ago

@bthirion this PR is ready to review

achamma723 commented 4 months ago

@bthirion, I think it is ready to be merged

bthirion commented 4 months ago

Merging now. Thx !

achamma723 commented 3 months ago

Hello @bthirion, I think this PR is ready to be merged.