search

mind-inria / mri-nufft

Doing non-Cartesian MR Imaging has never been so easy.
https://mind-inria.github.io/mri-nufft/
BSD 3-Clause "New" or "Revised" License
54 stars 10 forks source link

Have a trajectory learner example and reform the documentation build flow #167

Closed chaithyagr closed 4 months ago

chaithyagr commented 4 months ago

This is updated version of #142 , with rebase at #156 . Ideally we need #156 to go in after which we can merge this. Opened a new PR cause I dont know why I ended up with 2 branches and started working on this one :P

chaithyagr commented 4 months ago

I changed the base back to master to see the CD kick in and build docs. But I still dont see it.. @paquiteau what else do I need to do?

chaithyagr commented 4 months ago

Docs are generated, see here

chaithyagr commented 4 months ago

@alineyyy can you handle reviewing the trajectory learner example. @paquiteau will handle the general CI / CD and have a look at the docs etc.

chaithyagr commented 4 months ago

I will add @paquiteau to go through some "new" changes :P @alineyyy if you already started your review, please watchout for a lot of new changes... Can you please tell if the code is understandable and if required we can add more comments for clarity