Automatic shape update issue for sensitivity maps when changing n_coils with uses_sense

mind-inria / mri-nufft

Doing non-Cartesian MR Imaging has never been so easy.

https://mind-inria.github.io/mri-nufft/

BSD 3-Clause "New" or "Revised" License

51 stars 10 forks source link

Automatic shape update issue for sensitivity maps when changing n_coils with uses_sense #210

Open AsmaTANABEN opened 1 week ago

AsmaTANABEN commented 1 week ago

When uses_sense is enabled, changing n_coils does not automatically update the shape of sensitivity maps, resulting in errors. Specifically:

With the gpunufft backend, nufft.raw_op.pinned_smaps shape does not reflect the new coil number.
With the cufinufft backend, self._smaps shape does not change accordingly.

This leads to errors when updating sensitivity maps to match the new number of coils.

paquiteau commented 1 week ago

I don't quite get it. you modifies the number of coil dynamically ? why not simply create a new operator instead ?

chaithyagr commented 6 days ago

I think the use case is when you are learning reconstructor, but where dataset can be of different number of coils as input. This should be short I feel @AsmaTANABEN can you make a PR? The best way would be just to make n_coils a property with its setter.