search

mindcandy / Teamcity-unity3d-build-runner-plugin

A Teamcity plugin for building Unity3d projects. NOTE: this has an MIT license so feel free to copy / adapt as you need to.
107 stars 59 forks source link

auto-detect current version of unity installed (windows) #6

Closed markltbaker closed 11 years ago

markltbaker commented 11 years ago

The teamcity unity build runner has a hard-coded unity.version parameter. We should instead read this from the installed unity software.

(note - internal story at MC is TOOL-605)

markltbaker commented 11 years ago

ok, code for this on the Mac is now committed - https://github.com/mindcandy/Teamcity-unity3d-build-runner-plugin/commit/49cb7a4fc1b0ccbbe212464d453943362aaa34e5 - and we've tested this at Mind Candy.

However - we don't have any Windows build machines so we can't do this for Windows.

Basically the fix is to add something in UnityRunnerBuildServiceFactory.java setupConfigurationParameters() that will read from the registry entry or configuration file that exists on Windows.

I will leave this as an 'exercise for the reader' because we can't test it here. But I would love it someone could implement it and share their code back!

FriedrichWessel commented 11 years ago

I work on windows ( or at least have a machine for test and compile ). I just started today working on the possibility to change the Path to the Unity.exe ( because its hardcoded in the Moment, and I have different Unity Versions in non-standard folders) . First approach was to add a field in the Runner-Setup. But I think if we can get the versions we also can get the install path ? So maybe I can look into it. I will look into your fix the next days and check if I can make it run for Windows?

Friedrich

FriedrichWessel commented 11 years ago

Okay, just found Issue #7 ( sorry for that mixup ). So I will also handle this two steps as two Issues.

Looked into the Win-Registry yesterday, doesnt look like there is something in there for Unity Version. There is something to get the Mayor Versions, but not the Minor ones, because its saves as 3.x and 4.x.

Like on Mac there is an Info.plist in the Installfolder ( in the CFResoures Folder ), but the content is wrong - so this is not possible on Windows.

What I will try now is to read the Metadata of the exefile because there is a version in it.

markltbaker commented 11 years ago

That sounds great, thank you for the investigation on windows!

On Thursday, November 7, 2013, FriedrichWessel wrote:

Okay, just found Issue #7https://github.com/mindcandy/Teamcity-unity3d-build-runner-plugin/issues/7( sorry for that mixup ). So I will also handle this two steps as two Issues.

Looked into the Win-Registry yesterday, doesnt look like there is something in there for Unity Version. There is something to get the Mayor Versions, but not the Minor ones, because its saves as 3.x and 4.x.

Like on Mac there is an Info.plist in the Installfolder ( in the CFResoures Folder ), but the content is wrong - so this is not possible on Windows.

What I will try now is to read the Metadata of the exefile because there is a version in it.

— Reply to this email directly or view it on GitHubhttps://github.com/mindcandy/Teamcity-unity3d-build-runner-plugin/issues/6#issuecomment-27945023 .

Mark Baker Technology Lead, Tools

http://www.mindcandy.com http://www.moshimonsters.com

+44 (0) 7971 808 540 markb@mindcandy.com

markltbaker commented 11 years ago

Thanks again for this work - have merged the pull request now :)