minddust / bootstrap-progressbar

progressbar interactions for twitter bootstrap 2 & 3
www.minddust.com/project/bootstrap-progressbar
MIT License
577 stars 160 forks source link

[fix] HTML5 validator error #27

Closed ghost closed 10 years ago

ghost commented 10 years ago

When you validate site when is use bootstrap-progressbar plugin get a validation errors from aria-... atributes. To fix this problem add "data-" before aria-.. atributes, for example:

Change aria-valuetransitiongoal to data-aria-valuetransitiongoal

These changes should be made in the html file and in the file plugin.

40.        var aria_valuetransitiongoal = $this.attr('data-aria-valuetransitiongoal');
41.        var aria_valuemin = $this.attr('data-aria-valuemin') || 0;
42.        var aria_valuemax = $this.attr('data-aria-valuemax') || 100;
.
.
.
127.       $this.attr('data-aria-valuenow', current_value);
minddust commented 10 years ago

you are right about aria-valuetransitiongoal cause this isn't a valid aria attribute. i will change that to data with the next update.

all others valid by http://validator.w3.org/nu/

minddust commented 10 years ago

fixed with 0.8.0 (sorry for the delay)

jocar6562 commented 6 years ago

Hi Thank you for this info passes Val no errours johnc